Skip to content

Commit

Permalink
Update database template YAML to conform to spec (#400)
Browse files Browse the repository at this point in the history
* v4.11.0 (#379)

* Back to development

* Add Timestamps() macro when generating fizz migrations (#365)

* Azure pipelines (#367)

* WIP Azure pipelines

* Fix typo

* Fix soda install script

* Fix binary name

* Fix tsoda call

* Build soda without modules

* Use Bash to install soda

* Fix pipeline

* Fix soda build

* Remove go module builds

* Fix soda install

* Install soda with go install

* Fix config parse test

* Do not create Docker default DBs

* Remove Travis

* Update badge in Readme

* Remove legacy Anko format fixer (#366)

It can still be called using soda fix command.

* removes errors.WithStack as its noisy and makes it harder to understand (#372)

* removes errors.WithStack as its noisy and makes it harder to understand

* fix packr file

* Add a fix for old fizz without Timestamps() (#373)

* WIP fix old auto-timestamp

* Use plush AST to rewrite fizz files

* Fix case when files are already using t.Timestamps()

* Fix Windows line breaks issue

* Add a mention in godocs about the behavior on slices for executors (#375)

Fixes #363.

* Fix "has_one" pointer association (#378)

* hasOneAssociation did not work with pointers

* Bump version

* Fix IdlePool option (#380)

The zero value was not the same as in the stdlib and could cause
perfs issues. This will now not call SetMaxIdleConns when IdlePool
is set to the zero value.

Fixes #376

* Bump version

* Update database template YAML to conform to spec

This commit updates the four database template files to begin using
three hyphens, which per the YAML specification is used to signal the
start of a document.

While not invalid to not include this, as most of the tools don't
require this to properly function, by making this change ensures that
directives are properly parsed in all parsers.

```
3.2.3.4. Directives

Each document may be associated with a set of directives. A directive has a
name and an optional sequence of parameters. Directives are instructions to the
YAML processor, and like all other presentation details are not reflected in
the YAML serialization tree or representation graph. This version of YAML defines
a two directives, “YAML” and “TAG”. All other directives are reserved for future
versions of YAML.
```

* Revert version change
  • Loading branch information
kkirsche authored and stanislas-m committed Jun 20, 2019
1 parent 05102f3 commit a133d90
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

func Test_LoadsConnectionsFromConfig(t *testing.T) {
r := require.New(t)

r.NoError(LoadConfigFile())
if DialectSupported("sqlite3") {
r.Equal(5, len(Connections))
Expand Down
1 change: 1 addition & 0 deletions genny/config/templates/cockroach.yml.tmpl
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
development:
dialect: cockroach
database: {{.opts.Prefix}}_development
Expand Down
1 change: 1 addition & 0 deletions genny/config/templates/mysql.yml.tmpl
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
development:
dialect: "mysql"
database: "{{.opts.Prefix}}_development"
Expand Down
1 change: 1 addition & 0 deletions genny/config/templates/postgres.yml.tmpl
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
development:
dialect: postgres
database: {{.opts.Prefix}}_development
Expand Down
1 change: 1 addition & 0 deletions genny/config/templates/sqlite3.yml.tmpl
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
development:
dialect: "sqlite3"
database: {{.opts.Root}}_{{.opts.Prefix}}_development.sqlite
Expand Down

0 comments on commit a133d90

Please sign in to comment.