Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fix for old fizz without Timestamps() #373

Merged
merged 4 commits into from
Apr 8, 2019

Conversation

stanislas-m
Copy link
Member

No description provided.

@stanislas-m stanislas-m requested a review from a team as a code owner April 5, 2019 19:12
@stanislas-m stanislas-m merged commit a3d19f6 into development Apr 8, 2019
@stanislas-m stanislas-m deleted the task/fix-auto-timestamps branch April 8, 2019 12:21
stanislas-m added a commit that referenced this pull request May 5, 2019
* Back to development

* Add Timestamps() macro when generating fizz migrations (#365)

* Azure pipelines (#367)

* WIP Azure pipelines

* Fix typo

* Fix soda install script

* Fix binary name

* Fix tsoda call

* Build soda without modules

* Use Bash to install soda

* Fix pipeline

* Fix soda build

* Remove go module builds

* Fix soda install

* Install soda with go install

* Fix config parse test

* Do not create Docker default DBs

* Remove Travis

* Update badge in Readme

* Remove legacy Anko format fixer (#366)

It can still be called using soda fix command.

* removes errors.WithStack as its noisy and makes it harder to understand (#372)

* removes errors.WithStack as its noisy and makes it harder to understand

* fix packr file

* Add a fix for old fizz without Timestamps() (#373)

* WIP fix old auto-timestamp

* Use plush AST to rewrite fizz files

* Fix case when files are already using t.Timestamps()

* Fix Windows line breaks issue

* Add a mention in godocs about the behavior on slices for executors (#375)

Fixes #363.

* Fix "has_one" pointer association (#378)

* hasOneAssociation did not work with pointers

* Bump version

* Fix IdlePool option (#380)

The zero value was not the same as in the stdlib and could cause
perfs issues. This will now not call SetMaxIdleConns when IdlePool
is set to the zero value.

Fixes #376
stanislas-m pushed a commit that referenced this pull request Jun 20, 2019
* v4.11.0 (#379)

* Back to development

* Add Timestamps() macro when generating fizz migrations (#365)

* Azure pipelines (#367)

* WIP Azure pipelines

* Fix typo

* Fix soda install script

* Fix binary name

* Fix tsoda call

* Build soda without modules

* Use Bash to install soda

* Fix pipeline

* Fix soda build

* Remove go module builds

* Fix soda install

* Install soda with go install

* Fix config parse test

* Do not create Docker default DBs

* Remove Travis

* Update badge in Readme

* Remove legacy Anko format fixer (#366)

It can still be called using soda fix command.

* removes errors.WithStack as its noisy and makes it harder to understand (#372)

* removes errors.WithStack as its noisy and makes it harder to understand

* fix packr file

* Add a fix for old fizz without Timestamps() (#373)

* WIP fix old auto-timestamp

* Use plush AST to rewrite fizz files

* Fix case when files are already using t.Timestamps()

* Fix Windows line breaks issue

* Add a mention in godocs about the behavior on slices for executors (#375)

Fixes #363.

* Fix "has_one" pointer association (#378)

* hasOneAssociation did not work with pointers

* Bump version

* Fix IdlePool option (#380)

The zero value was not the same as in the stdlib and could cause
perfs issues. This will now not call SetMaxIdleConns when IdlePool
is set to the zero value.

Fixes #376

* Bump version

* Update database template YAML to conform to spec

This commit updates the four database template files to begin using
three hyphens, which per the YAML specification is used to signal the
start of a document.

While not invalid to not include this, as most of the tools don't
require this to properly function, by making this change ensures that
directives are properly parsed in all parsers.

```
3.2.3.4. Directives

Each document may be associated with a set of directives. A directive has a
name and an optional sequence of parameters. Directives are instructions to the
YAML processor, and like all other presentation details are not reflected in
the YAML serialization tree or representation graph. This version of YAML defines
a two directives, “YAML” and “TAG”. All other directives are reserved for future
versions of YAML.
```

* Revert version change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant