Return error from findMigrations #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Back to development * Add Timestamps() macro when generating fizz migrations (gobuffalo#365) * Azure pipelines (gobuffalo#367) * WIP Azure pipelines * Fix typo * Fix soda install script * Fix binary name * Fix tsoda call * Build soda without modules * Use Bash to install soda * Fix pipeline * Fix soda build * Remove go module builds * Fix soda install * Install soda with go install * Fix config parse test * Do not create Docker default DBs * Remove Travis * Update badge in Readme * Remove legacy Anko format fixer (gobuffalo#366) It can still be called using soda fix command. * removes errors.WithStack as its noisy and makes it harder to understand (gobuffalo#372) * removes errors.WithStack as its noisy and makes it harder to understand * fix packr file * Add a fix for old fizz without Timestamps() (gobuffalo#373) * WIP fix old auto-timestamp * Use plush AST to rewrite fizz files * Fix case when files are already using t.Timestamps() * Fix Windows line breaks issue * Add a mention in godocs about the behavior on slices for executors (gobuffalo#375) Fixes gobuffalo#363. * Fix "has_one" pointer association (gobuffalo#378) * hasOneAssociation did not work with pointers * Bump version * Fix IdlePool option (gobuffalo#380) The zero value was not the same as in the stdlib and could cause perfs issues. This will now not call SetMaxIdleConns when IdlePool is set to the zero value. Fixes gobuffalo#376
|
Those errors from CI look unrelated. Not sure what the issue is. |
stanislas-m
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
findMigrationsfunction used for initializing a file migrator doesn't currently return errors from walking a directory, but always returns nil.I'd expect this change to be more in line with API expectations, but not sure if downstream programs had been making false assumptions.
If I am mistaken in my understanding of this function, then we should add a comment that explains why it always returns nil.