TestObjectSignalHandling: fix/improve #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bus.Emit error was not checked, and since otherPath was invalid (had a hyphen), the signal was never emitted. Fix both issues. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
- embed fetchSignal into checkSignal; - remove t and timeout arguments; - add t.Helper so that errors show correct line number; Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
@guelfey PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing 3ddbb1d#r805311303
Please see individual commits for details.