Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestObjectSignalHandling: fix/improve #313

Merged
merged 2 commits into from
Feb 27, 2022
Merged

TestObjectSignalHandling: fix/improve #313

merged 2 commits into from
Feb 27, 2022

Commits on Feb 15, 2022

  1. TestObjectSignalHandling: fix/improve 

    bus.Emit error was not checked, and since otherPath was invalid
(had a hyphen), the signal was never emitted.

Fix both issues.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    81ff899 View commit details
    Browse the repository at this point in the history

  2. TestObjectSignalHandling: minor refactor 

     - embed fetchSignal into checkSignal;
 - remove t and timeout arguments;
 - add t.Helper so that errors show correct line number;

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    2c3cf65 View commit details
    Browse the repository at this point in the history