[HTML5] Synchronous main, better persistence, handlers fixes, optional full screen. #42178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add override keyword to RasterizerDummy methods. Plus cleanup unused methods, remove virtual keyword.
Faless
force-pushed
the
js/sync_fs_size_handlers
branch
from
58b12e8
to
50e5b46
Compare
|
Fixed silly bug in event listeners add/remove helpers. |
akien-mga
reviewed
Sep 23, 2020
|
|
||
| #include <emscripten/emscripten.h> | ||
| #include <stdlib.h> | ||
|
|
||
| static OS_JavaScript *os = nullptr; | ||
| static uint64_t target_ticks = 0; | ||
|
|
||
| extern "C" EMSCRIPTEN_KEEPALIVE void _request_quit_callback(char *p_filev[], int p_filec) { | ||
| if (os && os->get_main_loop()) { | ||
| os->get_main_loop()->notification(Node::NOTIFICATION_WM_CLOSE_REQUEST); |
There was a problem hiding this comment.
There seems to be DisplayServer::WINDOW_EVENT_CLOSE_REQUEST, which is what triggers emitting NOTIFICATION_WM_CLOSE_REQUEST in Window. Maybe this is better suited here than emitting a Node notification?
akien-mga
approved these changes
Sep 23, 2020
Crated helper class in native/utils.js. Simplify code in OS/DisplayServer.
The engine now expects to emscripten FS to be setup and sync-ed before main is called. This is exposed via `Module["initFS"]` which also allows to setup multiple persistence paths (internal use only for now). Additionally, FS syncing is done **once** for every loop if at least one file in a persistent path was open for writing and closed, and if the FS is not syncing already. This should potentially fix issues reported by users where "autosave" would not work on the web (never calling `syncfs` because of too many writes).
Faless
force-pushed
the
js/sync_fs_size_handlers
branch
from
50e5b46
to
dccd71c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has most of the things in #41097 (excluding the virtual keyboard support):
Plus, a rework of the initialization process to better handle file system synchronization (last commit, fixes #39643):
The engine now expects to emscripten FS to be setup and sync-ed before
main is called. This is exposed via
Module["initFS"]which also allowsto setup multiple persistence paths (internal use only for now).
Additionally, FS syncing is done once for every loop if at least one
file in a persistent path was open for writing and closed, and if the FS
is not syncing already.
This should potentially fix issues reported by users where "autosave"
would not work on the web (never calling
syncfsbecause of too manywrites).
There is a
3.2branch of all these changes for testing and easy cherry picking: https://github.com/Faless/godot/tree/js/3.0_sync_fs_size_handlersEDIT:
Converted to draft, there is a bug when de-registering events. Will update soonishFixed