Add a dynamic infinite grid to the 3D editor (3.2) #43206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 30, 2020
Calinou
force-pushed
the
add-dynamic-infinite-3d-grid
branch
from
0e6e95c
to
1e38105
Compare
akien-mga
reviewed
Oct 30, 2020
aaronfranke
reviewed
Oct 31, 2020
Calinou
force-pushed
the
add-dynamic-infinite-3d-grid
branch
from
1e38105
to
f2979e1
Compare
|
I applied #43272 locally on top, but then I noticed this PR causes constant redrawing as long as the grid is displayed. @aaronfranke Do you know how this could be fixed? Thanks in advance 🙂 |
Calinou
force-pushed
the
add-dynamic-infinite-3d-grid
branch
from
f2979e1
to
1bcb8ba
Compare
aaronfranke
force-pushed
the
add-dynamic-infinite-3d-grid
branch
from
1bcb8ba
to
e7bf64f
Compare
|
If we are backporting this, it might also make sense to backport #39743. An infinite grid might tempt users to zoom out really far and break the editor (as I did...), so we should prevent users from zooming to unreasonable levels. |
- The grid is now infinite, it follows the camera. - The grid is now dynamic, if you zoom in and out, the grid subdivides, expands, and fades. - You can now enable grid planes for the XY and YZ planes. Only the flat XZ plane is enabled by default. Each plane is independently dynamic of the others. - The default grid size has been increased to 200, and the maximum has been increased to 2000. At 1000, the grid mostly looks edgeless. - If you set the division level max and min to the same value then the grid does not expand or subdivide, but instead stays the same size and just follows the camera. Also, if these values are the same, the bias value does nothing. - If you want to have Blender-like behavior, set max to 1, min to 0, and set the bias to a really low value. You may also wish to increase the grid size if you have a small bias. Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
Calinou
force-pushed
the
add-dynamic-infinite-3d-grid
branch
from
e7bf64f
to
4b1de5b
Compare
|
Rebased on the latest |
akien-mga
approved these changes
Nov 17, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28289 to the
3.2branch.