Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move call to update the 3D grid into check for updating the view #43307

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Move call to update the 3D grid into check for updating the view #43307

merged 1 commit into from
Nov 4, 2020

Conversation

aaronfranke
Copy link
Member

Fixes a minor performance regression from #28289, found while testing #43206.

The update spinner still continuously spins, but at least now there is one fewer reason for that happening.

@aaronfranke aaronfranke added this to the 4.0 milestone Nov 4, 2020
@akien-mga akien-mga merged commit 3ec10bb into godotengine:master Nov 4, 2020
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the update-grid branch November 4, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug performance topic:editor topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronfranke @akien-mga