-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation is added #13
base: master
Are you sure you want to change the base?
Conversation
…xists, this is because it fails when there is no name field
If you have this problem and end up here from google search, you can add
Of course it would be really nice if this pr is merged and we would not have to pre-create catalog.json files to use this tap. |
if m["metadata"].get("real_name"): | ||
return m["metadata"]["real_name"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if m["metadata"].get("real_name"): | |
return m["metadata"]["real_name"] | |
return m["metadata"].get("real_name", None) |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to fix the issue 👍
Any chance we can have this merged in? @lidalei @halilduygulu I've seen other people on Meltano's Slack struggling with the same issue this PR resolves. |
I am not sure who is repo owner or monitoring PRs.
|
Got it, that's helpful! However, this commit is behind the master branch, which brings some important recent updates for the tap to work properly. Ideally, we'd always checkout from master to automatically get new update as they come too. Anyway, thanks for your help! |
Validation is added to confirm that the requested key ['real_name'] exists, this is because it fails when there is no name field