Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add id to key_properties when generating catalog #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add id to key_properties when generating catalog #18

wants to merge 2 commits into from

Conversation

lidalei
Copy link

@lidalei lidalei commented Feb 23, 2023 •
edited
Loading

This PR adds id to key_properties when generating catalog.json file. It also adds real_name to the id field's metadata.

Btw, this PR should fix the issue which another PR trying to fix.

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dutycycle dutycycle mentioned this pull request Jan 25, 2024
Merged
@alexmaras
Copy link

this fix was needed for this tap to work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidalei @alexmaras