-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Source Code Pro, version 2038 (roman), version 1.058 (italic),… #3346
Conversation
… version 1,018 (variable)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
- Depends on google/fonts#3346
@davelab6 @burnsra Since the font needs to be updated, I'd like to propose to fix the permissions over the files, because it has an executable permission which should not be necessary! I've already filled an issue #3342 and a pull request on #3343 to fix the wrong permission on Source Code Pro and other resources as well which I've found through the project. |
We just merged another version of Source Code Pro in #4010 so I close this PR. Won't be live on the API before few weeks though. Thanks for the work in any case. |
… version 1,018 (variable)