Check for Podman's auth.json in DefaultKeychain #1181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1145
This changes
authn.DefaultKeychain
to always check Podman's preferred auth config location (${XDG_RUNTIME_DIR}/containers/auth.json
) for auth configuration first, and only if that file doesn't exist, fallback to using Docker'sconfig.Load
and${DOCKER_CONFIG}
to look for the user's registry auth config.This matches Podman's documented behavior:
This may result in a subtle behavior change for users who have auth configured in both locations. Before this change, the Podman config would be ignored completely; after this change, it will be preferred over Docker's preferred location.