Attempt 2: Check for Podman's auth in DefaultKeychain #1185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt after #1181, reverted in #1184 due to #1183
The bug seems to be that if
$DOCKER_CONFIG
was unset, we would never look for$HOME/.docker/config.json
, whichconfig.Load
does.The order should be:
$HOME/.docker/config.json
<-- missing before; very common$DOCKER_CONFIG/config.json
$XDG_RUNTIME_DIR/containers/auth.json
(Podman auth)This is now reflected in this PR, with a unit test that builds up each option from 3->1 and checks that the correct auth config is used.
I'm open to more ideas about how to test this better, in case there are more edge cases I'm still not considering.