Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed warnings #2723

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Fixed warnings #2723

merged 1 commit into from
Mar 3, 2020

Conversation

JohanMabille
Copy link
Contributor

Backport of #2722

@kuzkry
Copy link
Contributor

kuzkry commented Feb 23, 2020

Hi! On releases webpage you will find release 1.10.0 and a note:

The 1.10.x will not consider any requests for any new features, The bug fix requests will only be considered if proven "critical"

Warning isn't critical, so this pull request targeting v.1.10.x branch should be abandoned.

@JohanMabille
Copy link
Contributor Author

This warning prevents to build gtest 1.10 with recent versions of gcc and you consider it as non critical?

@kuzkry
Copy link
Contributor

kuzkry commented Feb 23, 2020

It's only a warning after all. What prevents build is -Werror applied onto -Wsign-conversion.
Who knows, maybe GTest maintainers will accept it.

@JohanMabille
Copy link
Contributor Author

What prevents build is -Werror applied onto -Wsign-conversion.

Indeed, but I guess they set -Werror on purpose, so fixing the warning seems to be the thing to do rather than unsetting -Werror (or unsetting it for particular warnings).

@asoffer asoffer self-assigned this Mar 3, 2020
@asoffer asoffer merged commit 6a7ed31 into google:v1.10.x Mar 3, 2020
@JohanMabille JohanMabille deleted the warnings branch March 17, 2020 21:21
@JohanMabille JohanMabille restored the warnings branch March 18, 2020 09:44
uqs pushed a commit to freebsd/freebsd-src that referenced this pull request Apr 12, 2020
@ngie-eign
Backport a -Wsign-compare fix for ArrayAsVector
4d6db21 
This fixes the build with newer versions of gcc.

Obtained from: [google/googletest#2723](google/googletest#2723)
Submitted-by: [Johan Mabille](https://github.com/JohanMabille)
mat813 pushed a commit to mat813/freebsd that referenced this pull request Apr 14, 2020
Backport a -Wsign-compare fix for ArrayAsVector
2e83464 
This fixes the build with newer versions of gcc.

Obtained from: [google/googletest#2723](google/googletest#2723)
Submitted-by: [Johan Mabille](https://github.com/JohanMabille)


git-svn-id: https://svn.freebsd.org/base/vendor/google/googletest@359734 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
@DenizThatMenace DenizThatMenace mentioned this pull request Jun 2, 2020
Closed
@davidmerwin davidmerwin mentioned this pull request Aug 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asoffer asoffer

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohanMabille @kuzkry @asoffer @googlebot