[v1.10.x | backport] Fix -Wgnu-zero-variadic-macro-arguments in GMock
#2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing zero arguments to the variadic part of a macro is a GNU extension and triggers warnings when build projects using GMock with `-pedantic`. - Fix uses of `GMOCK_PP_INTERNAL_INTERNAL_16TH` to always receive at least 17 arguments. (This was triggered when `GMOCK_PP_NARG` or `GMOCK_PP_HAS_COMMA` were used with an argument containing no commas.) - Fix `GMOCK_PP_HEAD` to append a dummy unused argument so that `GMOCK_PP_INTERNAL_HEAD_CAT` always has two arguments. (backport of commit a09ea70)
|
Unfortunately we can't just accept backports for arbitrary issues into our releases. We will fix genuine bugs, but this is just a compile warning. Release stability is important. If you want the latest and greatest fixes, just use the master branch. |
|
This is not an "arbitrary issue". It is a hard compilation error for users enabling the "-pedantic-errors" (GCC) compiler option. This pull-request is no different than the former (latest) pull-request (#2723) accepted for this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing zero arguments to the variadic part of a macro is a GNU extension and triggers warnings when build projects using GMock with
-pedantic.GMOCK_PP_INTERNAL_INTERNAL_16THto always receive at least 17 arguments. (This was triggered whenGMOCK_PP_NARGorGMOCK_PP_HAS_COMMAwere used with an argument containing no commas).GMOCK_PP_HEADto append a dummy unused argument so thatGMOCK_PP_INTERNAL_HEAD_CATalways has two arguments.(backport of commit a09ea70)