Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Python: Include custom static files in generated Python docs #3020

Merged
merged 9 commits into from
Nov 8, 2019

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Nov 7, 2019

Allow extra static files in the generated docs so the Python 2 sunset banner can be added.

See googleapis/google-cloud-python#9036

image

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2019
@busunkim96
Copy link
Contributor Author

I have reached the end of my copy-pasta journey. @software-dov would you be able to take a look?

@software-dov
Copy link
Contributor

I feel like I'm the least qualified person to take a look at this review; I'm not great with the monolith, and I've looked at CSS classes for maybe 20 minutes of my life.

The screenshot looks great, and that's good enough for me.

@busunkim96 busunkim96 marked this pull request as ready for review November 7, 2019 18:11
@busunkim96
Copy link
Contributor Author

Chris pointed out that we can probably do most of this with synthtool templates. I'lll back out most of the changes here and just keep the change to docs/conf.py.

@busunkim96 busunkim96 changed the title Python: Add Python 2 sunset to generated docs Python: Allow custom static files into generated Python docs Nov 8, 2019
@busunkim96 busunkim96 changed the title Python: Allow custom static files into generated Python docs Python: Include custom static files in generated Python docs Nov 8, 2019
@busunkim96 busunkim96 requested review from crwilcox and removed request for yihanzhen November 8, 2019 21:43
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #3020 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3020   +/-   ##
========================================
  Coverage      87.1%   87.1%           
  Complexity     5952    5952           
========================================
  Files           491     491           
  Lines         23699   23699           
  Branches       2548    2548           
========================================
  Hits          20642   20642           
  Misses         2210    2210           
  Partials        847     847

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34da60e...337aaef. Read the comment docs.

@busunkim96 busunkim96 merged commit 99bcc78 into googleapis:master Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants