Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add python 2 EOL warning to reference documentation #9036

Merged
merged 6 commits into from
Nov 11, 2019

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 16, 2019

This PR adds a banner like the one below for all libraries:

Cloud Asset Python 2 Deprecation and EOL

@busunkim96 busunkim96 added the type: docs Improvement to the documentation for an API. label Aug 16, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2019
@crwilcox
Copy link
Contributor

crwilcox commented Nov 6, 2019

@busunkim96 busunkim96 changed the title Docs: Add Python 2 EOL warning to reference documentation. docs: add python 2 EOL warning to reference documentation. Nov 6, 2019
@busunkim96
Copy link
Contributor Author

Working on getting this added to the enerator

@busunkim96 busunkim96 marked this pull request as ready for review November 9, 2019 00:35
@busunkim96 busunkim96 requested a review from a team November 9, 2019 00:35
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for batching this up.

@busunkim96
Copy link
Contributor Author

Asset - system test failure (VPCSC)
BigQuery - system test failure (fixed in #9649)
Resource Manager - needs blackening
Security Center - snippets failure (resource names too long)
Storage - most likely a flake, failed only in 2.7
Trace - system test failure (VPCSC)

@busunkim96 busunkim96 changed the title docs: add python 2 EOL warning to reference documentation. docs: add python 2 EOL warning to reference documentation Nov 11, 2019
@tseaver
Copy link
Contributor

tseaver commented Nov 11, 2019

The current storage failure is an actual buggy unit test (query string parameter ordering):

E   Expected: request(data=<ANY>, headers=<ANY>, method='POST', url='https://storage.googleapis.com/storage/v1/b?project=OTHER_PROJECT&userProject=USER_PROJECT')
E   Actual: request(data='{"name": "bucket-name"}', headers={'Content-Type': 'application/json', 'X-Goog-API-Client': 'gcloud-python/1.22.0  gl-python/3.5.3 gax/1.14.3 gccl/1.22.0', 'User-Agent': 'gcloud-python/1.22.0  gl-python/3.5.3 gax/1.14.3 gccl/1.22.0', 'Accept-Encoding': 'gzip'}, method='POST', url='https://storage.googleapis.com/storage/v1/b?userProject=USER_PROJECT&project=OTHER_PROJECT')

Reported as #9714.

@busunkim96 busunkim96 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants