Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: drop Node 10 to support and update lastest Typescript #1252

Merged
merged 6 commits into from
May 9, 2022

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented May 4, 2022

Set Node v12 to minimum supported version

Drops Node 10 support, which has been EOL for about 1 year. 🦕

See: Google Cloud moves Cloud Client Libraries for Node.js support for version 10 to Maintenance

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner May 4, 2022 21:32
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 4, 2022
@summer-ji-eng summer-ji-eng changed the title build: drop Node 10 to support and update lastest Typescript build!: drop Node 10 to support and update lastest Typescript May 4, 2022
@summer-ji-eng summer-ji-eng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2022
@summer-ji-eng
Copy link
Contributor Author

@alexander-fenster I don't have access of setting to remove test(10) in gax-nodejs. Could you help me change to test(12). Thank you?

@alexander-fenster
Copy link
Contributor

alexander-fenster commented May 6, 2022

To remove node 10, change it here: https://github.com/googleapis/gax-nodejs/blob/main/.github/sync-repo-settings.yaml#L12, otherwise it will keep adding it. You can just send a separate PR to do it.

@sofisl
Copy link
Contributor

sofisl commented May 6, 2022

I think we just need to update auth, thank you!

@summer-ji-eng
Copy link
Contributor Author

I think we just need to update auth, thank you!

Upgraded. Thanks

@summer-ji-eng summer-ji-eng merged commit 88a180f into main May 9, 2022
@summer-ji-eng summer-ji-eng deleted the drop_node_10 branch May 9, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants