build!: drop Node 10 to support and update lastest Typescript

.github/sync-repo-settings.yaml

@@ -9,9 +9,9 @@ branchProtectionRules:
       - "ci/kokoro: System test"
       - docs
       - lint
-      - test (10)
       - test (12)
       - test (14)
+      - test (16)
       - cla/google
       - windows
       - OwlBot Post Processor

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [10, 12, 14]
+        node: [12, 14, 16]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

package.json

@@ -33,7 +33,7 @@
     "@types/fs-extra": "^9.0.0",
     "@types/mocha": "^9.0.0",
     "@types/ncp": "^2.0.1",
-    "@types/node": ">=15.6.0",
+    "@types/node": "^17.0.31",
     "@types/node-fetch": "^2.5.4",
     "@types/object-hash": "^2.1.0",
     "@types/proxyquire": "^1.3.28",
@@ -47,7 +47,7 @@
     "file-loader": "^6.0.0",
     "fs-extra": "^10.0.0",
     "google-proto-files": "^2.5.0",
-    "gts": "^2.0.0",
+    "gts": "^3.1.0",
     "is-docker": "^3.0.0",
     "json-loader": "^0.5.7",
     "karma": "^6.0.0",
@@ -71,7 +71,7 @@
     "sinon": "^13.0.0",
     "stream-events": "^1.0.4",
     "ts-loader": "^9.0.0",
-    "typescript": "^3.8.3",
+    "typescript": "^4.6.4",
     "walkdir": "^0.4.0",
     "webpack": "^5.0.0",
     "webpack-cli": "^4.0.0"
@@ -112,7 +112,7 @@
   },
   "homepage": "https://github.com/googleapis/gax-nodejs#readme",
   "engines": {
-    "node": ">=10"
+    "node": ">=12"
   },
   "browser": "build/src/fallback.js"
 }

src/streamingCalls/streaming.ts

@@ -17,7 +17,6 @@
 /* This file describes the gRPC-streaming. */
 
 import {Duplex, DuplexOptions, Readable, Stream, Writable} from 'stream';
-import {Metadata} from '@grpc/grpc-js';
 
 import {
   APICallback,
@@ -77,13 +76,6 @@ export enum StreamType {
   BIDI_STREAMING = 3,
 }
 
-interface Status {
-  code: number;
-  details: string;
-  message?: string;
-  metadata?: Metadata;
-}
-
 export class StreamProxy extends duplexify implements GRPCCallResult {
   type: StreamType;
   private _callback: APICallback;

test/browser-test/test.endtoend.ts

@@ -44,7 +44,7 @@ describe('Run tests against gRPC server', () => {
     port: 1337,
   };
 
-  // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore
   global.isBrowser = true;
   const client = new EchoClient(opts);

test/browser-test/test.grpc-fallback.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 
 import * as assert from 'assert';
 import {GoogleAuth} from 'google-auth-library';

test/browser-test/test.unit.ts

@@ -23,9 +23,7 @@ import {Transform} from 'stream';
 import {EchoClient} from '../fixtures/google-gax-packaging-test-app/src/v1beta1';
 import {GoogleAuth} from 'google-auth-library';
 import {GoogleError} from '../../src';
-interface Operation {
-  promise(): Function;
-}
+
 describe('Run unit tests of echo client', () => {
   interface GoogleError extends Error {
     code: number;

test/fixtures/google-gax-packaging-test-app/package.json

@@ -29,6 +29,6 @@
     "protobufjs": "^6.10.2"
   },
   "engines": {
-    "node": ">=10.0.0"
+    "node": ">=12.0.0"
   }
 }

test/fixtures/google-gax-packaging-test-app/src/index.ts

@@ -179,7 +179,7 @@ async function testEchoError(client: EchoClient) {
     Error);
   try {
       await client.echo(request);
-  } catch (err) {
+  } catch (err: any) {
       clearTimeout(timer);
       assert.strictEqual(JSON.stringify(err.statusDetails), JSON.stringify(expectedDetails));
       assert.ok(errorInfo!)

test/unit/bundling.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 /* eslint-disable no-prototype-builtins */
 
 import * as assert from 'assert';

test/unit/gax.ts

@@ -20,7 +20,7 @@
  * allowing that causes another errors of non-camelcase symbols anyways.
  * Therefore quote-props is disabled explicitly only in this file. */
 
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 
 import * as assert from 'assert';
 import {describe, it} from 'mocha';

test/unit/googleError.ts

@@ -141,6 +141,7 @@ describe('gRPC-google error decoding', () => {
     try {
       decoder.decodeProtobufAny(any);
     } catch (err) {
+      assert(err instanceof Error);
       assert.strictEqual(
         0,
         err
@@ -161,6 +162,7 @@ describe('gRPC-google error decoding', () => {
     try {
       decoder.decodeProtobufAny(any);
     } catch (err) {
+      assert(err instanceof Error);
       assert.strictEqual(0, err.toString().indexOf('Error: no such type'));
     }
   });

test/unit/grpc-fallback.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 /* eslint-disable no-undef */
 
 import * as assert from 'assert';

test/unit/grpc.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 /* eslint-disable no-prototype-builtins */
 /* eslint-disable @typescript-eslint/no-var-requires */
 

test/unit/longrunning.ts

@@ -668,7 +668,7 @@ describe('longrunning', () => {
           finalOperation: PENDING_OP,
         });
         const apiCall = createApiCall(func, client);
-        // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
         // @ts-ignore incomplete options
         apiCall(
           {},

test/unit/pagedIteration.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 /* eslint-disable no-prototype-builtins */
 
 import * as assert from 'assert';

test/unit/regapic.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/* xslint-disable @typescript-eslint/ban-ts-ignore */
+/* xslint-disable @typescript-eslint/ban-ts-comment */
 /* xslint-disable no-undef */
 
 import * as assert from 'assert';

test/unit/streaming.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 
 import * as assert from 'assert';
 import * as sinon from 'sinon';

test/unit/transcoding.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 
 import {describe, it} from 'mocha';
 import {RequestType} from '../../src/apitypes';