Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]:Fixed Grammatical Typo in Readme #3903

Closed
wants to merge 1 commit into from
Closed

[Fix]:Fixed Grammatical Typo in Readme #3903

wants to merge 1 commit into from

Conversation

JiyaGupta-cs
Copy link

@JiyaGupta-cs JiyaGupta-cs commented Oct 31, 2023 •
edited
Loading

1st error:
image

2nd error:
image

@JiyaGupta-cs
Copy link
Author

@gorhill Please review and merge this fix. I am aiming for Hacktoberfest and today is the last day.

@JiyaGupta-cs JiyaGupta-cs changed the title [Fix]:Fixed Grammatical Error in Readme [Fix]:Fixed Grammatical Typo in Readme Oct 31, 2023
bilalmirza74
bilalmirza74 approved these changes Oct 31, 2023
View reviewed changes
Copy link

@bilalmirza74 bilalmirza74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gorhill
Copy link
Owner

gorhill commented Oct 31, 2023

I am declining this, I don't want to encourage that sort of pull requests, see https://blog.domenic.me/hacktoberfest/.

Also, https://en.wikipedia.org/wiki/Hosts_(file)

@gorhill gorhill closed this Oct 31, 2023
@gorhill gorhill mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilalmirza74 bilalmirza74 bilalmirza74 approved these changes

Assignees
No one assigned
Labels
declined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JiyaGupta-cs @gorhill @bilalmirza74