-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional flag to the Persian list #2946
Comments
I am going to revert the |
@gorhill Please see:
Ok, I will re-open this issue once more sites are covered. |
I honest-to-gods didn't know that non-contributors weren't allowed to reply to PRs there. If it's needed for me to apologise for that, I give my apologies. |
You are you apologizing for something that's not your doing. It takes only one accepted PR to become contributor, it's not me specifically picking people, I just limit the repo "to prior contributors" in moderation settings to avoid that sort of interaction. |
Next time, please ask the relevant list owners for feedback first. I had notified you on Slack but it was ignored. |
Slack has scared me in the past month, and I've been terrified of going back there. Far too heavy gatekeeping attempts of channels. |
Since @DandelionSprout had used his "special privilege" of being a past-contributor, I couldn't reply on this pull request.
I think it's best to make an issue under
uBlockOrigin/uBlock-issues
to allow for an open discussion.That PR completely ignores that the Persian list also supports Pashto sites from Afghanistan, so I propose this change:
gorhill/uBlock@2b9af08
gorhill/uBlock@63f94bf
The text was updated successfully, but these errors were encountered: