Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional flag to the Persian list #2946

Closed
MasterKia opened this issue Nov 9, 2023 · 6 comments
Closed

Add additional flag to the Persian list #2946

MasterKia opened this issue Nov 9, 2023 · 6 comments
Labels
enhancement New feature or request TODO todo

Comments

@MasterKia
Copy link
Member

MasterKia commented Nov 9, 2023

Since @DandelionSprout had used his "special privilege" of being a past-contributor, I couldn't reply on this pull request.

I think it's best to make an issue under uBlockOrigin/uBlock-issues to allow for an open discussion.

That PR completely ignores that the Persian list also supports Pashto sites from Afghanistan, so I propose this change:
gorhill/uBlock@2b9af08
gorhill/uBlock@63f94bf

@gwarser gwarser added the enhancement New feature or request label Nov 9, 2023
@gorhill
Copy link
Member

gorhill commented Nov 9, 2023

I am going to revert the .tj one. There are no .af in your list, and only 8 instances of .tj in the list, not enough to justify the change. I set a rule of at least 5% TLD before considering adding a flag in another discussion.

@MasterKia
Copy link
Member Author

There are no .af in your list

@gorhill Please see:
https://github.com/MasterKia/PersianBlocker/blob/ad8db3d11805870065df8eb3abf539269ca240f0/PersianBlocker.txt#L4086

not enough to justify the change

Ok, I will re-open this issue once more sites are covered.

@MasterKia MasterKia closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@MasterKia MasterKia added the TODO todo label Nov 9, 2023
gorhill added a commit to gorhill/uBlock that referenced this issue Nov 9, 2023
@DandelionSprout
Copy link

I honest-to-gods didn't know that non-contributors weren't allowed to reply to PRs there. If it's needed for me to apologise for that, I give my apologies.

@gorhill
Copy link
Member

gorhill commented Nov 9, 2023

You are you apologizing for something that's not your doing.

It takes only one accepted PR to become contributor, it's not me specifically picking people, I just limit the repo "to prior contributors" in moderation settings to avoid that sort of interaction.

@MasterKia
Copy link
Member Author

Next time, please ask the relevant list owners for feedback first. I had notified you on Slack but it was ignored.

@DandelionSprout
Copy link

DandelionSprout commented Nov 9, 2023

Slack has scared me in the past month, and I've been terrified of going back there. Far too heavy gatekeeping attempts of channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TODO todo
Projects
None yet
Development

No branches or pull requests

4 participants