Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional flags to regional lists #3904

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented Nov 3, 2023

In large part inspired by the success of AnXh3L0/blocklist#10, I felt the time was right to attempt to add more flags to some lists.

I feel 100.00% confident in the new flags for Adblock List for Albania, Romanian Ad (ROad) Block List Light, and PersianBlocker. MasterKia himself can confirm the relevance of the latter one first-hand.

I at least don't think the Turkish sector on Cyprus use the main Cyprus flag to any real extent, so using the Cyprus flag for the Greek list seems safe to me.

Suriname for EasyDutch probably needs some explanation: Suriname has Dutch as its sole administrative language, which is more than what can be said about Belgium or ZA Afrikaans. And while there's only 2 relevant newssites in Suriname, both have strong coverage in EasyDutch.

I did however not wager a guess for flags for AdGuard Français. I obviously can't add Belgian or Swiss flags, and there's not all that many newssites in Monaco, Cameroon, or Senegal.

Adding the Faroese flag to Nordic Filters was tempting (and Bosnia-Hercegovina's flag to Serbo-Croatian List), but I didn't want to make it look like I was the focus of the PR.

@gorhill
Copy link
Owner

gorhill commented Nov 6, 2023

All good except for "Adblock List for Albania", I looked in the list and there are no instance of .xk being used.

@DandelionSprout
Copy link
Contributor Author

DandelionSprout commented Nov 6, 2023

That's the thing: Various internet TLD authorities never actually got around to opening up .xk for use, so Kosovo sites have to use other TLDs instead. At the time of writing, a Kosovo-specific section is at the bottom of that list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants