Move initialization of multi KV runtime watcher into initRuntimeConfig function #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g function. This fixes problem where Mimir-derived subproject overriding "ruler" init method wouldn't wire the runtime config watcher properly. This change also fixes problem where ruler/querier wouldn't have watcher installed for watching store-gateway ring. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
force-pushed
the
fix-multikv-init
branch
from
c3f5b7a
to
b598f2b
Compare
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR moves initialization of multi KV runtime watcher into
initRuntimeConfigfunction.This fixes problem where Mimir-derived subproject overriding "ruler" init method wouldn't wire the runtime config watcher properly. This PR also fixes problem where ruler and querier wouldn't have runtime config watcher for multi KV installed for
querier-store-gatewayKV.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]