Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move initialization of multi KV runtime watcher into initRuntimeConfig function #1665

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Move initialization of multi KV runtime watcher into initRuntimeConfig function #1665

merged 3 commits into from
Apr 8, 2022

Commits on Apr 8, 2022

  1. Move initialization of multi KV runtime watcher into initRuntimeConfi… 

    …g function.

This fixes problem where Mimir-derived subproject overriding "ruler"
init method wouldn't wire the runtime config watcher properly.

This change also fixes problem where ruler/querier wouldn't have watcher
installed for watching store-gateway ring.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
    @pstibrany
    pstibrany committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    9beb70a View commit details
    Browse the repository at this point in the history

  2. Added CHANGELOG.md 

    Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
    @pstibrany
    pstibrany committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    b598f2b View commit details
    Browse the repository at this point in the history

  3. Test for Compactor and its ring too. 

    Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
    @pstibrany
    pstibrany committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    be465a2 View commit details
    Browse the repository at this point in the history