Track cortex_query_frontend_enqueue_duration_seconds by query-scheduler #6120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
charleskorn
approved these changes
Sep 25, 2023
| @@ -68,10 +68,10 @@ func newFrontendSchedulerWorkers(cfg Config, frontendAddress string, requestsCh | |||
| Name: "cortex_query_frontend_workers_enqueued_requests_total", | |||
There was a problem hiding this comment.
Should we remove or deprecate this metric? We'll be able to get the same information at with cortex_query_frontend_enqueue_duration_seconds now.
There was a problem hiding this comment.
Separate PR, see: #6121. We offer no guarantee on metrics, so no need to deprecate: we can just remove it (moreover it's not used in any of the dashboards / alerts we provide).
3 tasks
charleskorn
approved these changes
Sep 26, 2023
Delete the metric when disconnects from a query-scheduler Customise cortex_query_frontend_enqueue_duration_seconds buckets Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
track-query-frontend-enqueue-duration-per-query-scheduler
branch
from
a78e6ce
to
a1d515a
Compare
pracucci
deleted the
track-query-frontend-enqueue-duration-per-query-scheduler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR addresses a feedback received here. In this PR I proposes to track
cortex_query_frontend_enqueue_duration_secondsbyquery-scheduleraddress, to have better visibility in case the slowdown is caused by a specific scheduler.I've also took the opportunity to customise the
cortex_query_frontend_enqueue_duration_secondshistogram buckets, to track 1ms latency too and removing any bucket bigger than 1s.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]