Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cortex_query_frontend_workers_enqueued_requests_total metric #6121

Merged

Conversation

pracucci
Copy link
Collaborator

What this PR does

We recently introduced cortex_query_frontend_enqueue_duration_seconds (histogram) for the query-frontend even when the query-scheduler is in use. This makes the cortex_query_frontend_workers_enqueued_requests_total obsolete, because cortex_query_frontend_enqueue_duration_seconds_count can be used instead of cortex_query_frontend_workers_enqueued_requests_total.

In this PR I propose to remove cortex_query_frontend_workers_enqueued_requests_total metric. I checked alerts and dashboards, and it doesn't look to be used anywhere.

This PR builds on #6120.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci force-pushed the track-query-frontend-enqueue-duration-per-query-scheduler branch from a78e6ce to a1d515a Compare September 26, 2023 14:25
Base automatically changed from track-query-frontend-enqueue-duration-per-query-scheduler to main September 26, 2023 14:51
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the remove-cortex_query_frontend_workers_enqueued_requests_total branch from 8d99ba6 to f9767a9 Compare September 26, 2023 15:13
@pracucci pracucci marked this pull request as ready for review September 26, 2023 15:15
@pracucci pracucci requested a review from a team as a code owner September 26, 2023 15:15
@pracucci pracucci enabled auto-merge (squash) September 26, 2023 15:16
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 6e0038d into main Sep 26, 2023
28 checks passed
@pracucci pracucci deleted the remove-cortex_query_frontend_workers_enqueued_requests_total branch September 26, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants