distributor: pass write request size via metadata #6490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
3 tasks
56quarters
reviewed
Oct 27, 2023
pkg/distributor/distributor_test.go
Outdated
| require.NoError(t, err) | ||
|
|
||
| // Verify that d.send added message size to metadata. | ||
| require.NotEmpty(t, strconv.Itoa(req.Size()), mock.md[grpcutil.MetadataMessageSize]) |
There was a problem hiding this comment.
I'm not sure this is asserting what we want it to be asserting?
We're asserting that strconv.Itoa(size) is not empty but even a request size of 0 will be converted to "0" which isn't an empty string. Also I don't understand why we're passing the metadata as the msgAndArgs argument to require.NotEmpty().
There was a problem hiding this comment.
I'm not sure this is asserting what we want it to be asserting?
You're right, it should be equality test. Fixed in 5ff6b54.
francoposa
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Distributor: pass size of write request in grpc metadata. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR makes distributor to pass size of WriteRequest in gRPC request metadata. That allows ingester to check for the size before reading request into memory.
Changelog will be added after implementing request size check on ingesters. (#6492)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]