ingester: implement request size instance limit #6492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2023
pracucci
approved these changes
Oct 27, 2023
| if err := i.checkAvailable(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| inflight := i.inflightPushRequests.Inc() | ||
| decreaseInflightInDefer := true | ||
| inflightBytes := int64(0) |
There was a problem hiding this comment.
If we don't know the requestSize we may want to set inflightBytes to i.inflightPushRequestsBytes.Load() so that the later check runs at least on the inflight requests for which size was known.
There was a problem hiding this comment.
Thanks, that's a great point. I'll add test for this as well, and double-check if we do the same on distributor.
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
…ytes error. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
… known. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
force-pushed
the
ingester-size-check
branch
from
6472990
to
6b294ad
Compare
…works. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR implements total request size instance limit. Works best in combination with
-ingester.limit-inflight-requests-using-grpc-method-limiterflag, and distributors with #6490.Which issue(s) this PR fixes or relates to
Previous attempt #5958, rejected because the check is not very effective when done from inside Push handler in ingester.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]