-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow S3 Storage Provider to support sts_endpoint #6990
Allow S3 Storage Provider to support sts_endpoint #6990
Conversation
…mKotowski/mimir into allow-sts-endpoint-s3-storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the contribution.
I left a few minor comments/questions. I also see some of the linting and unit tests are failing. The messages within CI should have instructions on how to resolve them. Let me know if you need any help.
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
… endpoint passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter is complaining about import statement ordering, and I left a couple of minor comments. Other than that I think this is ready for a merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, appreciate the time you spent!
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
I pushed a commit to address the linter errors. PR should be good to merge now |
@dimitarvdimitrov ty for fixing the lint, was super busy yesterday. Hopefully when I am off my windows machine, when my new mac comes I can address these linting issues with the specified make commands. Appreciate you fixing |
Safe to merge then once all pipelines pass? |
What this PR does
Minio has added sts support to work with the k8s service account JWTs. Allow STS Endpoint support for S3 storage provider by providing it in Mimirs s3Config.
Which issue(s) this PR fixes or relates to
#6172
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.