Allow S3 Storage Provider to support sts_endpoint

pkg/storage/bucket/s3/config.go

@@ -44,6 +44,7 @@ var (
 	errUnsupportedStorageClass     = fmt.Errorf("unsupported S3 storage class (supported values: %s)", strings.Join(supportedStorageClasses, ", "))
 	errInvalidSSEContext           = errors.New("invalid S3 SSE encryption context")
 	errInvalidEndpointPrefix       = errors.New("the endpoint must not prefixed with the bucket name")
+	errInvalidSTSPrefix            = errors.New("sts-endpoint must be a valid url")
 )
 
 // HTTPConfig stores the http.Transport configuration for the s3 minio client.
@@ -128,6 +129,9 @@ func (cfg *Config) Validate() error {
 			return errInvalidEndpointPrefix
 		}
 	}
+	if cfg.STSEndpoint != "" && !util.IsValidURL(cfg.STSEndpoint) {
+		return errInvalidSTSPrefix
+	}
 	if !util.StringsContain(supportedStorageClasses, cfg.StorageClass) && cfg.StorageClass != "" {
 		return errUnsupportedStorageClass
 	}

pkg/storage/bucket/s3/config_test.go

@@ -118,6 +118,20 @@ func TestConfig_Validate(t *testing.T) {
 			},
 		},
 		"should pass with using sts endpoint": {
+			setup: func() *Config {
+				sseCfg := &SSEConfig{}
+				flagext.DefaultValues(sseCfg)
+				cfg := &Config{
+					BucketName:       "mimir-block",
+					SSE:              *sseCfg,
+					SignatureVersion: SignatureVersionV4,
+					StorageClass:     s3_service.StorageClassStandard,
+					STSEndpoint:      "https://sts.eu-central-1.amazonaws.com",
+				}
+				return cfg
+			},
+		},
+		"should not pass with using sts endpoint as its using an invalid url": {
 			setup: func() *Config {
 				sseCfg := &SSEConfig{}
 				flagext.DefaultValues(sseCfg)
@@ -130,6 +144,7 @@ func TestConfig_Validate(t *testing.T) {
 				}
 				return cfg
 			},
+			expected: errInvalidSTSPrefix,
 		},
 	}
 

pkg/util/url.go

@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+
+package util
+
+import (
+	"net/url"
+)
+
+func IsValidURL(endpoint string) bool {
+	u, err := url.Parse(endpoint)
+	if err != nil {
+		return false
+	}
+
+	return u.Scheme != "" && u.Host != ""
+}

pkg/util/url_test.go

@@ -0,0 +1,45 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+package util
+
+import (
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestIsValidURL(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		name     string
+		endpoint string
+	}{
+		{
+			name:     "valid url",
+			endpoint: "https://sts.eu-central-1.amazonaws.com",
+		},
+		{
+			name:     "invalid url no scheme",
+			endpoint: "sts.eu-central-1.amazonaws.com",
+		},
+		{
+			name:     "invalid url invalid scheme setup",
+			endpoint: "https:///sts.eu-central-1.amazonaws.com",
+		},
+		{
+			name:     "invalid url no host",
+			endpoint: "https://",
+		},
+	}
+
+	for i, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			valid := IsValidURL(test.endpoint)
+
+			if i == 0 {
+				assert.True(t, valid)
+			} else {
+				assert.False(t, valid)
+			}
+		})
+	}
+}