Fix out of order exemplar error for native histograms #7640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of prometheus/prometheus#13021 When receiving multiple exemplars for a native histogram in mimir via remote write, only report an error if all are older than the latest exemplar as this could be a partial update. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
beorn7
approved these changes
Mar 17, 2024
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
beorn7
previously approved these changes
Mar 17, 2024
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
56quarters
approved these changes
Mar 18, 2024
| @@ -88,6 +88,13 @@ func (req *WriteRequest) AddHistogramSeries(lbls [][]LabelAdapter, histograms [] | |||
| return req | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
nit: It's a simple method but could you add a doc comment?
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
|
For the record: I did test doing the sort in the distributor, however that would trigger a remarshalling of the remote write request and that's probably more costly than doing the sort in place. |
krajorama
added a commit
that referenced
this pull request
Apr 5, 2024
* Fix out of order exemplar error for native histograms Port of prometheus/prometheus#13021 When receiving multiple exemplars for a native histogram in mimir via remote write, sort them and only report an error if all are older than the latest exemplar as this could be a partial update. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> cherry pick from def7165
krajorama
added a commit
that referenced
this pull request
Apr 5, 2024
* Fix out of order exemplar error for native histograms Port of prometheus/prometheus#13021 When receiving multiple exemplars for a native histogram in mimir via remote write, sort them and only report an error if all are older than the latest exemplar as this could be a partial update. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> cherry pick from def7165
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What this PR does
When receiving multiple exemplars for a native histogram in Mimir via remote write, sort them and only report an error if all are older than the latest exemplar as this could be a partial update.
Which issue(s) this PR fixes or relates to
Port of prometheus/prometheus#13021
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.