Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r282] backport Fix out of order exemplar error for native histograms pr 7640 #7820

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

krajorama
Copy link
Contributor

  • Fix out of order exemplar error for native histograms

Port of prometheus/prometheus#13021

When receiving multiple exemplars for a native histogram in mimir via remote write, sort them and only report an error if all are older than the latest exemplar as this could be a partial update.

Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com

cherry pick from def7165

* Fix out of order exemplar error for native histograms

Port of prometheus/prometheus#13021

When receiving multiple exemplars for a native histogram in mimir via
remote write, sort them and only report an error if all are older than the latest
exemplar as this could be a partial update.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

cherry pick from def7165
@krajorama krajorama requested a review from a team as a code owner April 5, 2024 13:07
@krajorama
Copy link
Contributor Author

Note: already included in r283, so no need to backport more.

Copy link
Member

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krajorama krajorama enabled auto-merge (squash) April 5, 2024 13:16
@krajorama krajorama merged commit 0baa229 into r282 Apr 5, 2024
29 checks passed
@krajorama krajorama deleted the krajo/r282-backport-pr7640 branch April 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants