store-gateway: Add timeout for index-header loading gate #8138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/index-header-timeout
branch
2 times, most recently
from
181e8d1
to
bd0c495
Compare
56quarters
force-pushed
the
56quarters/index-header-timeout
branch
from
bd0c495
to
6f304ef
Compare
This change introduces an optional timeout on the gate used to limit the concurrency of index-header loads. This helps in cases where a store-gateway may have to load a large index-header before it can serve a query. This prevents and unbounded number of requests from blocking while index-headers are loaded. Fixes #8137 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
2 tasks
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/index-header-timeout
branch
from
6f304ef
to
6f76a52
Compare
francoposa
pushed a commit
that referenced
this pull request
May 27, 2024
* store-gateway: Add timeout for index-header loading gate This change introduces an optional timeout on the gate used to limit the concurrency of index-header loads. This helps in cases where a store-gateway may have to load a large index-header before it can serve a query. This prevents and unbounded number of requests from blocking while index-headers are loaded. Fixes #8137 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Note experimental flag and add comment Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This change introduces an optional timeout on the gate used to limit the concurrency of index-header loads. This helps in cases where a store-gateway may have to load a large index-header before it can serve a query. This prevents and unbounded number of requests from blocking while index-headers are loaded.
Which issue(s) this PR fixes or relates to
Fixes #8137
Related #7777
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.