Mimir query engine: rename metrics and CLI flag values to match new name #8291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
approved these changes
Jun 6, 2024
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
…ame (grafana#8291) * Rename metrics * Update flag names * Update names used in tests and benchmarks * Update changelog * Fix test
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We've started referring to the new query engine as the "Mimir query engine" rather than the "streaming query engine", and the existing query engine as "Prometheus' query engine".
This PR updates the metrics emitted by the engine and the values of the
-querier.promql-engineCLI flag to match this new preferred name.I haven't renamed the
streamingpromqlpackage as that will be disruptive to in-progress PRs - we can change this later if it really annoys us.Which issue(s) this PR fixes or relates to
Follow up to #8270
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.