Mimir query engine: update description for -querier.enable-promql-engine-fallback CLI flag
#8455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gine-fallback` CLI flag
jhesketh
reviewed
Jun 21, 2024
cmd/mimir/config-descriptor.json
Outdated
| @@ -1924,7 +1924,7 @@ | |||
| "kind": "field", | |||
| "name": "enable_promql_engine_fallback", | |||
| "required": false, | |||
| "desc": "If set to true and the streaming engine is in use, fall back to using the Prometheus PromQL engine for any queries not supported by the streaming engine.", | |||
| "desc": "If set to true and the Mimir PromQL engine is in use, fall back to using the Prometheus PromQL engine for any queries not supported by the Mimir PromQL engine.", | |||
There was a problem hiding this comment.
I thought we were calling it "Mimir Query Engine"? It leaves open the possibility of extending it and we've been using the MQE acronym.
There was a problem hiding this comment.
I was debating this - the flag name uses the term "PromQL engine", so I was trying to be consistent with that.
I'll change the term here.
jhesketh
approved these changes
Jun 21, 2024
I did a quick search through the codebase, I couldn't find any more instances apart from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates the description for the
-querier.enable-promql-engine-fallbackCLI flag to match the name change in #8291.Which issue(s) this PR fixes or relates to
#8291
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.