Skip to content

Commit

Permalink
Merge pull request #35 from guardian/LIVE-5387-add-empty-card-type
Browse files Browse the repository at this point in the history
LIVE-5387 Add an empty card type to fix the problem with the last card being stretched in carousel
  • Loading branch information
waisingyiu committed Jul 31, 2023
2 parents d408e05 + 40f5174 commit 9c5e82b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions proto/collection.proto
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ message Card {
*/
CARD_TYPE_DISPLAY = 5;
CARD_TYPE_MOSTVIEWED = 6;
/**
* An empty card is used to indicate an empty space so that the native
* client do not stretch the previous card to occupy the space
*/
CARD_TYPE_EMPTY = 7;
}
CardType type = 1;
Article article = 2;
Expand Down
4 changes: 4 additions & 0 deletions proto/proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@
{
"name": "CARD_TYPE_MOSTVIEWED",
"integer": 6
},
{
"name": "CARD_TYPE_EMPTY",
"integer": 7
}
]
},
Expand Down

0 comments on commit 9c5e82b

Please sign in to comment.