Add an empty card type #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We see that on a carousel row with 2 cards in each column, if we have an odd number of cards resulting in a single card only in the last column, this card is stretched to fit the whole column. What we expect is to keep all the cards the same size and just leave the empty space there.
One solution we are going to implement is to indicate in the blueprint response that there is empty space where a card would be.
The PR is to add to the schema a new card type
EMPTY_CARD_TYPEso that we are able to indicate where to leave the space (the same size as a card) empty in the layout.