[Fairground] Add a property to indicate the heading style. Replace the title property. #109
Conversation
waisingyiu
force-pushed
the
fairground/add-heading-style-for-collections
branch
from
d376bc6
to
77f4fe1
Compare
| * The title of this collection for display. It replaces | ||
| * the old "title" property. | ||
| */ | ||
| optional string display_title = 20; |
There was a problem hiding this comment.
Should title be marked as deprecated too?
There was a problem hiding this comment.
Once the title is marked as deprecated, MAPI cannot access this property. But at this stage, we should still populate title in order not to break existing versions of the app.
|
@waisingyiu has published a preview version of this PR with release workflow run #71, based on commit 77f4fe1: 1.0.26-PREVIEW.fairgroundadd-heading-style-for-collections.2024-09-18T1127.77f4fe14 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the fairground/add-heading-style-for-collections branch, or use the GitHub CLI command: gh workflow run release.yml --ref fairground/add-heading-style-for-collections Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
What does this change?
We have to support at least three styles for a collection title for the new design of the homepage:
Previously, we tell the apps to hide the title by not populating the
titleproperty. However, we found that we need to show title elsewhere (for example, homepage customisation page) even if we don't show it on the front.After discussion, we agree to create a new property to indicate in what style to display the title. In this schema, we should always provide the title. We have to add a new title property and deprecate the existing one in order not to break the existing version of the app.