Add unspecified value for every enum #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohammad-haque @guardian-ben - does this change meet your expectations or I need to re-think the approach? |
|
This looks much better to me compare to the current version of _UNSPECIFIED fields. This will require some change in the client side but that would be small piece of work. |
|
@guardian-ben @mohammad-haque - if we're happy with this approach would someone be able to approve please? |
mohammad-haque
approved these changes
Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds an intentional
unspecifiedvalue to every enum. This should increase the robustness of the schema by explicitly defining default/fallback values (meaning the client code can explicitly handle these cases).