[fairground] Add new attributes for card UI introduced by new dynamic layouts #94
Conversation
waisingyiu
changed the title
waisingyiu
force-pushed
the
fairground/new-card-ui-for-dynamic-containers
branch
from
16bae4f
to
821b087
Compare
waisingyiu
changed the title
waisingyiu
force-pushed
the
fairground/new-card-ui-for-dynamic-containers
branch
from
821b087
to
02af26b
Compare
|
@waisingyiu has published a preview version of this PR with release workflow run #45, based on commit 02af26b: 1.0.21-PREVIEW.fairgroundnew-card-ui-for-dynamic-containers.2024-07-22T1541.02af26b0 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the fairground/new-card-ui-for-dynamic-containers branch, or use the GitHub CLI command: gh workflow run release.yml --ref fairground/new-card-ui-for-dynamic-containers Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
| * Define constants for the arrangement of sublinks on a card | ||
| */ | ||
| enum SublinksArrangement { | ||
| SUBLINKS_ARRANGEMENT_UNSPECIFIED = 0; |
There was a problem hiding this comment.
I'm curious - why do we need unspecified? Is this a protobuf requirement?
There was a problem hiding this comment.
It provides a way for client code to handle default/fallback values - #31
The constant which is mapped to 0 in an enum is the default value in protobuf format.
What does this change?
We are going to build new card UIs based on the design of new dynamic containers as part of the homepage redesign project.
This pull request adds new attributes to schema so that MAPI can provide the native apps with directives which UI variant to use to render each card.