Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to electron v7 #132

Open
raffis opened this issue Oct 31, 2018 · 4 comments
Open

Upgrade to electron v7 #132

raffis opened this issue Oct 31, 2018 · 4 comments
Labels
change hasfix
Milestone
1.3.x

Comments

@raffis
Copy link
Contributor

raffis commented Oct 31, 2018

Description

https://electronjs.org/releases#3.0.0

Bundled with nodejs v10 which fixes nodejs/node#12115, therefore we can switch from https://github.com/gyselroth/node-windows-fsstat to ino big int support.

balloon desktop version

Your client operating system

Filesystem (If known)

balloon server version (If known)
@raffis raffis added the change label Oct 31, 2018
@raffis raffis mentioned this issue Oct 31, 2018
Closed
@pixtron
Copy link
Member

pixtron commented Nov 7, 2018

Updated in dev branch

@pixtron
Copy link
Member

pixtron commented Nov 7, 2018

PR nodejs/node/pull/20220 was released with node 10.5.0 electron 3.0.8 bundles only node 10.2.0.

So far we can't replace gyselroth/node-windows-fsstat.

@raffis raffis changed the title Upgrade to electron v3.x Upgrade to electron v4.x Nov 29, 2018
@raffis raffis added this to the 1.0.x milestone Nov 29, 2018
@raffis
Copy link
Contributor Author

raffis commented Nov 29, 2018

Upgrade to electron 4.x beta7

pixtron added a commit that referenced this issue Nov 29, 2018
@pixtron
Upgrade electron to 4.0.0-beta.7
41e9d2a 
Related to: #132
@raffis raffis modified the milestones: 1.0.x, 2.0.x Dec 7, 2018
@raffis
Copy link
Contributor Author

raffis commented Dec 7, 2018

electron/electron#14941 is a show stopper for this project. Reverted to electron v2 for v1.0.0

@raffis raffis mentioned this issue Dec 7, 2018
Open
@raffis raffis modified the milestones: 2.0.x, 1.3.x Nov 14, 2019
@raffis raffis changed the title Upgrade to electron v4.x Upgrade to electron v7 Nov 14, 2019
@pixtron pixtron mentioned this issue Nov 14, 2019
Open
@raffis raffis mentioned this issue Nov 20, 2019
Closed
pixtron added a commit that referenced this issue Jan 8, 2020
@pixtron
Upgrade to electron 7
92115a6 
Related to: #132
Related to: #141
@pixtron pixtron mentioned this issue Jan 8, 2020
Closed
pixtron added a commit that referenced this issue Jan 10, 2020
@pixtron
Update balloon-node-sync to v0.6.0
1e42a70 
Mainly removes @gyselroth/windows-fsstat dependency.

Related to: #132
@pixtron pixtron added the hasfix label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change hasfix
Projects
None yet
Milestone
1.3.x
Development

No branches or pull requests
2 participants
@pixtron @raffis