Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use app.requestSingleInstanceLock instead of app.makeSingleInstance #141

Open
pixtron opened this issue Nov 6, 2018 · 2 comments
Open

Use app.requestSingleInstanceLock instead of app.makeSingleInstance #141

pixtron opened this issue Nov 6, 2018 · 2 comments
Labels
change hasfix
Milestone
1.3.x

Comments

@pixtron
Copy link
Member

pixtron commented Nov 6, 2018

Description

Is:
'app.makeSingleInstance(cb)' is deprecated. Use 'app.requestSingleInstanceLock() and app.on('second-instance', cb)' instead.
@pixtron pixtron added this to the 1.0.x milestone Nov 29, 2018
@pixtron
Copy link
Member Author

pixtron commented Nov 29, 2018

Needed for upgrade to electron 4.x

@pixtron pixtron added the hasfix label Nov 29, 2018
@raffis raffis modified the milestones: 1.0.x, 2.0.x Dec 7, 2018
@raffis raffis added change and removed hasfix labels Dec 7, 2018
@raffis
Copy link
Contributor

raffis commented Dec 7, 2018

Needs to be reimplemented after #132

@raffis raffis closed this as completed in fef8cda Dec 21, 2018
@pixtron pixtron modified the milestones: 2.0.x, 1.3.x Nov 14, 2019
@pixtron pixtron reopened this Nov 14, 2019
pixtron added a commit that referenced this issue Jan 8, 2020
@pixtron
Upgrade to electron 7
92115a6 
Related to: #132
Related to: #141
@pixtron pixtron added the hasfix label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change hasfix
Projects
None yet
Milestone
1.3.x
Development

No branches or pull requests
2 participants
@pixtron @raffis