Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: sort Gradle config into more reusable pieces with less redundancy #15282

Draft
wants to merge 1 commit into
base: jendrik-dev-tmp
Choose a base branch
from

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Aug 30, 2024

Description:

As preparation to move things into a separate repository. (WiP)

Candidates for separate PRs:

  • move:gradle/versions
  • move gradle/aggregation and use for consistent resolution
  • Publishing, developers.properties, description.txt
  • gradle/jdk-version.txt

Related issue(s):

#14255

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jjohannes jjohannes self-assigned this Aug 30, 2024
@jjohannes jjohannes added this to the v0.55 milestone Sep 2, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 2 times, most recently from 9f31f6d to c629b6e Compare September 2, 2024 07:11
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 4 times, most recently from df441df to a1831af Compare September 6, 2024 14:22
Copy link

codacy-production bot commented Sep 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c4b25881
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c4b2588) Report Missing Report Missing Report Missing
Head commit (6289854) 98279 60489 61.55%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15282) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (jendrik-dev-tmp@c4b2588). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             jendrik-dev-tmp   #15282   +/-   ##
==================================================
  Coverage                   ?   57.91%           
  Complexity                 ?    19519           
==================================================
  Files                      ?     2669           
  Lines                      ?    98462           
  Branches                   ?    10202           
==================================================
  Hits                       ?    57023           
  Misses                     ?    37835           
  Partials                   ?     3604           

Impacted file tree graph

@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 3 times, most recently from 6dcaef1 to 056f81a Compare September 9, 2024 06:24
@jjohannes jjohannes changed the base branch from develop to jendrik-dev-tmp September 16, 2024 08:18
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants