Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: generalize publishing setup #15471

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Sep 16, 2024

Description:

Do not have 'hedera-services' specifics in plugins so that they may be reused without modification in other repositories.

For this, we introduce two files in the folder for each "product"

  • developers.properties
  • description.txt (optional)

See changes in the PR for what these files contain.

Related issue(s):

#14255 / #15282

Notes for reviewer:

The information moved into the developers.properties files end up in the Metadata of the published Jars. E.g. here:
https://repo1.maven.org/maven2/com/hedera/hashgraph/hapi/0.53.5/hapi-0.53.5.pom

Please share if you have alternative/better suggestion for where we should maintain this information.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

hedera-base@swirldslabs.com=Hedera Base Team
hedera-services@swirldslabs.com=Hedera Services Team
hedera-smart-contracts@swirldslabs.com=Hedera Smart Contracts Team
release-engineering@swirldslabs.com=Release Engineering Team
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For symmetry, I would suggest to move hapi one level up into hapi/hapi. Even if it is just one "Module" in the "Product". (In a separate PR.)

Copy link

codacy-production bot commented Sep 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8dfd416) 109347 67530 61.76%
Head commit (342deef) 109347 (+0) 67524 (-6) 61.75% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15471) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.20%. Comparing base (8dfd416) to head (342deef).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15471      +/-   ##
=============================================
- Coverage      58.21%   58.20%   -0.01%     
- Complexity     21617    21618       +1     
=============================================
  Files           2785     2785              
  Lines         109530   109530              
  Branches       11210    11210              
=============================================
- Hits           63764    63757       -7     
- Misses         41890    41896       +6     
- Partials        3876     3877       +1     

see 8 files with indirect coverage changes

Impacted file tree graph

Comment on lines 3 to 6
hedera-base@swirldslabs.com=Hedera Base Team
hedera-services@swirldslabs.com=Hedera Services Team
hedera-smart-contracts@swirldslabs.com=Hedera Smart Contracts Team
release-engineering@swirldslabs.com=Release Engineering Team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are phasing out swirldlabs.com and moving to hashgraph.com

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be the same addresses for the teams, just replace the domain? Then I can do that as part of this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, maybe @poulok knows, or @nathanklick

Do not have 'hedera-services' specifics in plugins so that they may
be reused without modification in other repositories.

For this, we introduce two files in the folder for each "product"
- developers.properties
- description.txt (optional)

See changes in the PR for what these files contain.

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants