-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: generalize publishing setup #15471
base: develop
Are you sure you want to change the base?
Conversation
b4dac0c
to
c18df8e
Compare
developers.properties
Outdated
hedera-base@swirldslabs.com=Hedera Base Team | ||
hedera-services@swirldslabs.com=Hedera Services Team | ||
hedera-smart-contracts@swirldslabs.com=Hedera Smart Contracts Team | ||
release-engineering@swirldslabs.com=Release Engineering Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For symmetry, I would suggest to move hapi
one level up into hapi/hapi
. Even if it is just one "Module" in the "Product". (In a separate PR.)
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15471 +/- ##
=============================================
- Coverage 58.21% 58.20% -0.01%
- Complexity 21617 21618 +1
=============================================
Files 2785 2785
Lines 109530 109530
Branches 11210 11210
=============================================
- Hits 63764 63757 -7
- Misses 41890 41896 +6
- Partials 3876 3877 +1 |
developers.properties
Outdated
hedera-base@swirldslabs.com=Hedera Base Team | ||
hedera-services@swirldslabs.com=Hedera Services Team | ||
hedera-smart-contracts@swirldslabs.com=Hedera Smart Contracts Team | ||
release-engineering@swirldslabs.com=Release Engineering Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are phasing out swirldlabs.com
and moving to hashgraph.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be the same addresses for the teams, just replace the domain? Then I can do that as part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, maybe @poulok knows, or @nathanklick
c18df8e
to
51745f7
Compare
Do not have 'hedera-services' specifics in plugins so that they may be reused without modification in other repositories. For this, we introduce two files in the folder for each "product" - developers.properties - description.txt (optional) See changes in the PR for what these files contain. Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
51745f7
to
342deef
Compare
Description:
Do not have 'hedera-services' specifics in plugins so that they may be reused without modification in other repositories.
For this, we introduce two files in the folder for each "product"
See changes in the PR for what these files contain.
Related issue(s):
#14255 / #15282
Notes for reviewer:
The information moved into the
developers.properties
files end up in the Metadata of the published Jars. E.g. here:https://repo1.maven.org/maven2/com/hedera/hashgraph/hapi/0.53.5/hapi-0.53.5.pom
Please share if you have alternative/better suggestion for where we should maintain this information.
Checklist