SideNav::List::Title: wrap text of long strings (HDS-3047)
#1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s will wrap, update css for backlink so long strings will wrap
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
reviewed
Jan 23, 2024
packages/components/addon/components/hds/side-nav/list/title.hbs
Outdated
Show resolved
Hide resolved
packages/components/app/styles/components/side-nav/content.scss
Outdated
Show resolved
Hide resolved
|
Made refinements from feedback. |
…essary wrapping of adjacent text in layout
KristinLBradley
commented
Jan 23, 2024
| @@ -616,12 +624,16 @@ | |||
| </SG.Item> | |||
| <SG.Item @label="Icon + text + yielded content"> | |||
| <Hds::SideNav::List::Link @icon="boundary" @text="Boundary"> | |||
| <Shw::Placeholder @height="20px" @text="yielded content" /> | |||
| {{! template-lint-disable no-inline-styles }} | |||
| <Shw::Placeholder @height="20px" @width="auto" style="flex-grow: 1;" @text="yielded content" /> | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
KristinLBradley
commented
Jan 23, 2024
packages/components/tests/dummy/app/templates/components/side-nav.hbs
Outdated
Show resolved
Hide resolved
didoo
approved these changes
Jan 24, 2024
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
KristinLBradley
deleted the
hds-3047-fix-sidenav-list-title-text-wrapping
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR restructures the SidNav ListTitle DOM and updates styles so long unbroken text strings will wrap. It also updates css for
SideNav::List::BackLinkso long text strings will wrap.📸 Screenshots
🔗 External links
Jira ticket: HDS-3047
👀 Component checklist
A11y tests have been run locally (yarn test:a11y --filter="COMPONENT-NAME")If documenting a new component, an acceptance test that includes thea11yAudithas been added💬 Please consider using conventional comments when reviewing this PR.