Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SideNav::List::Title: wrap text of long strings (HDS-3047) #1899

Merged
merged 7 commits into from
Jan 24, 2024
Merged

SideNav::List::Title: wrap text of long strings (HDS-3047) #1899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c247cd7
HDS-3047 Restructure SideNav List Title and update css so long string…
KristinLBradley Jan 22, 2024
e1fe6d3
HDS-3047 Add changeset
KristinLBradley Jan 22, 2024
7bad392
HDS-3047 Make refinements from feedback
KristinLBradley Jan 23, 2024
7fa76a1
HDS-3047 Modify placeholders to be flexible so they don't force unnec…
KristinLBradley Jan 23, 2024
f2585b5
HDS-3047 Replace non-working arguments for height and width with inli…
KristinLBradley Jan 23, 2024
01ff0cd
HDS-3047 Add flex argument to placeholder to replace inline styles
KristinLBradley Jan 24, 2024
c4aaa2e
Update .changeset/few-emus-walk.md
KristinLBradley Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-emus-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": patch
---

`SideNav::List::Title`, `SideNav::List::BackLink`, `SideNav::List::Link`: fixed issue with long text strings without spaces not wrapping
7 changes: 4 additions & 3 deletions packages/components/app/styles/components/side-nav/content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,18 @@
// (LIST) TITLE

.hds-side-nav__list-title {
display: flex;
align-items: center;
min-height: var(--token-side-nav-body-list-item-height);
margin-top: var(--token-side-nav-body-list-margin-vertical);
padding: 9px var(--token-side-nav-body-list-item-padding-horizontal); // 8px = (min-height - body-100-line-height) / 2
color: var(--token-side-nav-color-foreground-faint);
overflow-wrap: break-word;

// Remove margin from title at top of all list-items & lists
.hds-side-nav__list-wrapper:first-child .hds-side-nav__list-item:first-child > & {
margin-top: 0;
}
}


// LIST (root elements)

.hds-side-nav__list-wrapper, // <nav> element
Expand Down Expand Up @@ -147,8 +145,11 @@
// LIST ITEM > INNER ELEMENTS

.hds-side-nav__list-item-text {
min-width: 0;
max-width: 100%;
KristinLBradley marked this conversation as resolved.
Show resolved Hide resolved
color: var(--token-side-nav-color-foreground-primary);
text-align: left;
overflow-wrap: break-word;
}

.hds-side-nav__list-item-icon-leading {
Expand Down
4 changes: 4 additions & 0 deletions packages/components/tests/dummy/app/components/shw/placeholder/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ export default class PlaceholderIndexComponent extends Component {
if (this.args.background) {
styles.push(`background: ${this.args.background}`);
}
if (this.args.flex) {
styles.push(`flex: ${this.args.flex}`);
}

return styles.length > 0 ? htmlSafe(styles.join('; ')) : undefined;
}
}
17 changes: 15 additions & 2 deletions packages/components/tests/dummy/app/templates/components/side-nav.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,14 @@
</Hds::SideNav::List::Item>
</ul>
</SF.Item>
<SF.Item @label="With very long text and no spaces">
<ul class="shw-component-sim-side-nav-body">
<Hds::SideNav::List::Title>ThisIsLongTextThatShouldWrapToTwoLinesAndNotOverflow</Hds::SideNav::List::Title>
<Hds::SideNav::List::Item>
<Shw::Placeholder @height="108px" @text="following content" />
</Hds::SideNav::List::Item>
</ul>
</SF.Item>
</Shw::Flex>

<Shw::Divider @level={{2}} />
Expand Down Expand Up @@ -616,12 +624,12 @@
</SG.Item>
<SG.Item @label="Icon + text + yielded content">
<Hds::SideNav::List::Link @icon="boundary" @text="Boundary">
<Shw::Placeholder @height="20px" @text="yielded content" />
<Shw::Placeholder @height="20px" @width="auto" @flex="1 1 0" @text="yielded content" />
</Hds::SideNav::List::Link>
</SG.Item>
<SG.Item @label="With hasSubItems">
<Hds::SideNav::List::Link @icon="boundary" @text="Boundary" @hasSubItems={{true}}>
<Shw::Placeholder @height="20px" @text="yielded content" />
<Shw::Placeholder @height="20px" @width="auto" @flex="1 1 0" @text="yielded content" />
</Hds::SideNav::List::Link>
</SG.Item>
<SG.Item @label="Text with no style">
Expand Down Expand Up @@ -723,6 +731,11 @@
<Hds::SideNav::List::BackLink @text="This is a long text that should go on two lines" @href="#" />
</ul>
</SF.Item>
<SF.Item @label="With very long text and no spaces">
<ul class="shw-component-sim-side-nav-body">
<Hds::SideNav::List::BackLink @text="ThisIsLongTextThatShouldWrapToTwoLinesAndNotOverflow" @href="#" />
</ul>
</SF.Item>
</Shw::Flex>

<Shw::Text::H4>States</Shw::Text::H4>
Expand Down