Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_route: 'destination_prefix_list_id' attribute can be specified for managed prefix list destinations #17291

Merged
merged 9 commits into from
Mar 29, 2021
Merged

r/aws_route: 'destination_prefix_list_id' attribute can be specified for managed prefix list destinations #17291

merged 9 commits into from
Mar 29, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 26, 2021 •
edited by YakDriver
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Builds on: #14014, #16930, #16961
Dependents: #17295

Relates: #15273.
Replaces #17275.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_disappears_RouteTable
=== PAUSE TestAccAWSRoute_disappears_RouteTable
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv6_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv6_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv4_To_CarrierGateway
=== PAUSE TestAccAWSRoute_IPv4_To_CarrierGateway
=== RUN   TestAccAWSRoute_IPv4_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv4_To_LocalGateway
=== RUN   TestAccAWSRoute_IPv6_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv6_To_LocalGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== RUN   TestAccAWSRoute_IPv4_Update_Target
=== PAUSE TestAccAWSRoute_IPv4_Update_Target
=== RUN   TestAccAWSRoute_IPv6_Update_Target
=== PAUSE TestAccAWSRoute_IPv6_Update_Target
=== RUN   TestAccAWSRoute_IPv4_To_VpcEndpoint
=== PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint
=== RUN   TestAccAWSRoute_LocalRoute
=== PAUSE TestAccAWSRoute_LocalRoute
=== RUN   TestAccAWSRoute_PrefixList_To_InternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_InternetGateway
=== RUN   TestAccAWSRoute_PrefixList_To_VpnGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_VpnGateway
=== RUN   TestAccAWSRoute_PrefixList_To_Instance
=== PAUSE TestAccAWSRoute_PrefixList_To_Instance
=== RUN   TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_PrefixList_To_NatGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_NatGateway
=== RUN   TestAccAWSRoute_PrefixList_To_TransitGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_TransitGateway
=== RUN   TestAccAWSRoute_PrefixList_To_CarrierGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_CarrierGateway
=== RUN   TestAccAWSRoute_PrefixList_To_LocalGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_LocalGateway
=== RUN   TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway (34.30s)
=== CONT  TestAccAWSRoute_PrefixList_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_PrefixList_To_LocalGateway (1.39s)
=== CONT  TestAccAWSRoute_PrefixList_To_CarrierGateway
--- PASS: TestAccAWSRoute_basic (36.19s)
=== CONT  TestAccAWSRoute_PrefixList_To_TransitGateway
--- PASS: TestAccAWSRoute_PrefixList_To_CarrierGateway (32.87s)
=== CONT  TestAccAWSRoute_PrefixList_To_NatGateway
--- PASS: TestAccAWSRoute_PrefixList_To_NatGateway (176.98s)
=== CONT  TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_PrefixList_To_VpcPeeringConnection (33.36s)
=== CONT  TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_PrefixList_To_TransitGateway (379.41s)
=== CONT  TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached (62.90s)
=== CONT  TestAccAWSRoute_PrefixList_To_Instance
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached (364.41s)
=== CONT  TestAccAWSRoute_PrefixList_To_VpnGateway
--- PASS: TestAccAWSRoute_PrefixList_To_VpnGateway (60.04s)
=== CONT  TestAccAWSRoute_PrefixList_To_InternetGateway
--- PASS: TestAccAWSRoute_PrefixList_To_InternetGateway (34.69s)
=== CONT  TestAccAWSRoute_LocalRoute
--- PASS: TestAccAWSRoute_LocalRoute (22.35s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcEndpoint
--- PASS: TestAccAWSRoute_PrefixList_To_Instance (306.41s)
=== CONT  TestAccAWSRoute_IPv6_Update_Target
--- PASS: TestAccAWSRoute_IPv6_Update_Target (217.12s)
=== CONT  TestAccAWSRoute_IPv4_Update_Target
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (303.13s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (52.31s)
=== CONT  TestAccAWSRoute_IPv6_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.14s)
=== CONT  TestAccAWSRoute_IPv4_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.07s)
=== CONT  TestAccAWSRoute_IPv4_To_CarrierGateway
--- PASS: TestAccAWSRoute_IPv4_To_CarrierGateway (24.23s)
=== CONT  TestAccAWSRoute_IPv6_To_TransitGateway
=== CONT  TestAccAWSRoute_IPv4_Update_Target        
--- PASS: TestAccAWSRoute_IPv4_Update_Target (292.84s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (336.06s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (42.42s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (357.41s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (25.58s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (209.45s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (135.25s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (57.79s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (76.36s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (55.43s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (61.25s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (344.44s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (26.00s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (59.16s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (34.89s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (37.72s)
=== CONT  TestAccAWSRoute_disappears_RouteTable
--- PASS: TestAccAWSRoute_disappears_RouteTable (33.42s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_disappears (32.43s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (328.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2418.681s

@ewbankkit ewbankkit requested a review from a team as a code owner January 26, 2021 20:20
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 26, 2021
@ewbankkit ewbankkit mentioned this pull request Jan 26, 2021
Closed
@ewbankkit ewbankkit force-pushed the f-r/aws_route-managed_prefix_list-destination branch from f919951 to ef6982c Compare January 26, 2021 20:22
@ewbankkit ewbankkit mentioned this pull request Jan 26, 2021
Merged
@ewbankkit

This comment has been minimized.

Sign in to view
@randyspainhower
Copy link

update on this? I need to do exactly this, I can manually add the prefix list to the route table but cannot do it through terraform....

@YakDriver YakDriver self-assigned this Mar 25, 2021
This was referenced Mar 25, 2021
Merged
Merged
Merged
@ewbankkit ewbankkit force-pushed the f-r/aws_route-managed_prefix_list-destination branch from 9588dc8 to ba14669 Compare March 26, 2021 20:19
@ewbankkit @YakDriver
r/aws_route: 'destination_prefix_list_id' attribute can be specified …
7fafa81 
…for managed prefix list destinations.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute_basic -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_basic
--- PASS: TestAccAWSRoute_basic (35.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.619s
@ewbankkit @YakDriver
r/aws_route: Add 'TestAccAWSRoute_PrefixList_To_InternetGateway'.
4529240 
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute_PrefixList_To_InternetGateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute_PrefixList_To_InternetGateway -timeout 120m
=== RUN   TestAccAWSRoute_PrefixList_To_InternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_InternetGateway
=== CONT  TestAccAWSRoute_PrefixList_To_InternetGateway
--- PASS: TestAccAWSRoute_PrefixList_To_InternetGateway (36.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.149s
@ewbankkit @YakDriver
r/aws_route: Add prefix list destination tests.
9bc9f57 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_PrefixList_To_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_PrefixList_To_ -timeout 120m
=== RUN   TestAccAWSRoute_PrefixList_To_InternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_InternetGateway
=== RUN   TestAccAWSRoute_PrefixList_To_VpnGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_VpnGateway
=== RUN   TestAccAWSRoute_PrefixList_To_Instance
=== PAUSE TestAccAWSRoute_PrefixList_To_Instance
=== RUN   TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_PrefixList_To_NatGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_NatGateway
=== RUN   TestAccAWSRoute_PrefixList_To_TransitGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_TransitGateway
=== RUN   TestAccAWSRoute_PrefixList_To_LocalGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_LocalGateway
=== RUN   TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
=== CONT  TestAccAWSRoute_PrefixList_To_InternetGateway
=== CONT  TestAccAWSRoute_PrefixList_To_NatGateway
--- PASS: TestAccAWSRoute_PrefixList_To_InternetGateway (35.99s)
=== CONT  TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway (32.09s)
=== CONT  TestAccAWSRoute_PrefixList_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_PrefixList_To_LocalGateway (1.13s)
=== CONT  TestAccAWSRoute_PrefixList_To_TransitGateway
--- PASS: TestAccAWSRoute_PrefixList_To_NatGateway (200.00s)
=== CONT  TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached (65.18s)
=== CONT  TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_PrefixList_To_VpcPeeringConnection (33.28s)
=== CONT  TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_PrefixList_To_TransitGateway (368.99s)
=== CONT  TestAccAWSRoute_PrefixList_To_Instance
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached (350.96s)
=== CONT  TestAccAWSRoute_PrefixList_To_VpnGateway
--- PASS: TestAccAWSRoute_PrefixList_To_VpnGateway (47.82s)
--- PASS: TestAccAWSRoute_PrefixList_To_Instance (327.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	765.354s
@ewbankkit @YakDriver
Add CHANGELOG entry.
204962d
@ewbankkit @YakDriver
r/aws_route: Don't check prefix list owner on import.
86fab31
@ewbankkit @YakDriver
r/aws_route: Add acceptance test pre-checks.
7947cbc 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_PrefixList_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_PrefixList_ -timeout 120m
=== RUN   TestAccAWSRoute_PrefixList_To_InternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_InternetGateway
=== RUN   TestAccAWSRoute_PrefixList_To_VpnGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_VpnGateway
=== RUN   TestAccAWSRoute_PrefixList_To_Instance
=== PAUSE TestAccAWSRoute_PrefixList_To_Instance
=== RUN   TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_PrefixList_To_NatGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_NatGateway
=== RUN   TestAccAWSRoute_PrefixList_To_TransitGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_TransitGateway
=== RUN   TestAccAWSRoute_PrefixList_To_CarrierGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_CarrierGateway
=== RUN   TestAccAWSRoute_PrefixList_To_LocalGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_LocalGateway
=== RUN   TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
=== CONT  TestAccAWSRoute_PrefixList_To_InternetGateway
=== CONT  TestAccAWSRoute_PrefixList_To_NatGateway
--- PASS: TestAccAWSRoute_PrefixList_To_InternetGateway (36.30s)
=== CONT  TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway (32.35s)
=== CONT  TestAccAWSRoute_PrefixList_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_PrefixList_To_LocalGateway (1.19s)
=== CONT  TestAccAWSRoute_PrefixList_To_CarrierGateway
--- PASS: TestAccAWSRoute_PrefixList_To_CarrierGateway (32.74s)
=== CONT  TestAccAWSRoute_PrefixList_To_TransitGateway
--- PASS: TestAccAWSRoute_PrefixList_To_NatGateway (179.80s)
=== CONT  TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached (66.06s)
=== CONT  TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_PrefixList_To_VpcPeeringConnection (33.19s)
=== CONT  TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_PrefixList_To_TransitGateway (368.36s)
=== CONT  TestAccAWSRoute_PrefixList_To_Instance
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached (351.56s)
=== CONT  TestAccAWSRoute_PrefixList_To_VpnGateway
--- PASS: TestAccAWSRoute_PrefixList_To_VpnGateway (50.39s)
--- PASS: TestAccAWSRoute_PrefixList_To_Instance (328.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	799.400s
@ewbankkit @YakDriver
r/aws_route: Add 'ErrorCheck' to new acceptance tests.
5caf2e9 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 180m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_disappears_RouteTable
=== PAUSE TestAccAWSRoute_disappears_RouteTable
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv6_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv6_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv4_To_CarrierGateway
=== PAUSE TestAccAWSRoute_IPv4_To_CarrierGateway
=== RUN   TestAccAWSRoute_IPv4_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv4_To_LocalGateway
=== RUN   TestAccAWSRoute_IPv6_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv6_To_LocalGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== RUN   TestAccAWSRoute_IPv4_Update_Target
=== PAUSE TestAccAWSRoute_IPv4_Update_Target
=== RUN   TestAccAWSRoute_IPv6_Update_Target
=== PAUSE TestAccAWSRoute_IPv6_Update_Target
=== RUN   TestAccAWSRoute_IPv4_To_VpcEndpoint
=== PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint
=== RUN   TestAccAWSRoute_LocalRoute
=== PAUSE TestAccAWSRoute_LocalRoute
=== RUN   TestAccAWSRoute_PrefixList_To_InternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_InternetGateway
=== RUN   TestAccAWSRoute_PrefixList_To_VpnGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_VpnGateway
=== RUN   TestAccAWSRoute_PrefixList_To_Instance
=== PAUSE TestAccAWSRoute_PrefixList_To_Instance
=== RUN   TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_PrefixList_To_NatGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_NatGateway
=== RUN   TestAccAWSRoute_PrefixList_To_TransitGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_TransitGateway
=== RUN   TestAccAWSRoute_PrefixList_To_CarrierGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_CarrierGateway
=== RUN   TestAccAWSRoute_PrefixList_To_LocalGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_LocalGateway
=== RUN   TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_disappears_RouteTable
--- PASS: TestAccAWSRoute_disappears_RouteTable (34.77s)
=== CONT  TestAccAWSRoute_IPv4_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (0.57s)
=== CONT  TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_basic (36.83s)
=== CONT  TestAccAWSRoute_PrefixList_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_PrefixList_To_LocalGateway (0.98s)
=== CONT  TestAccAWSRoute_PrefixList_To_CarrierGateway
--- PASS: TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway (33.33s)
=== CONT  TestAccAWSRoute_PrefixList_To_TransitGateway
--- PASS: TestAccAWSRoute_PrefixList_To_CarrierGateway (33.36s)
=== CONT  TestAccAWSRoute_PrefixList_To_NatGateway
--- PASS: TestAccAWSRoute_PrefixList_To_NatGateway (209.25s)
=== CONT  TestAccAWSRoute_PrefixList_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_PrefixList_To_VpcPeeringConnection (33.13s)
=== CONT  TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_PrefixList_To_TransitGateway (400.32s)
=== CONT  TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached (65.97s)
=== CONT  TestAccAWSRoute_PrefixList_To_Instance
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached (349.30s)
=== CONT  TestAccAWSRoute_PrefixList_To_VpnGateway
--- PASS: TestAccAWSRoute_PrefixList_To_VpnGateway (59.18s)
=== CONT  TestAccAWSRoute_PrefixList_To_InternetGateway
--- PASS: TestAccAWSRoute_PrefixList_To_InternetGateway (35.44s)
=== CONT  TestAccAWSRoute_LocalRoute
--- PASS: TestAccAWSRoute_LocalRoute (22.13s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcEndpoint
--- PASS: TestAccAWSRoute_PrefixList_To_Instance (328.02s)
=== CONT  TestAccAWSRoute_IPv6_Update_Target
--- PASS: TestAccAWSRoute_IPv6_Update_Target (221.14s)
=== CONT  TestAccAWSRoute_IPv4_Update_Target
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (387.03s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (54.14s)
=== CONT  TestAccAWSRoute_IPv6_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (0.57s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (58.78s)
=== CONT  TestAccAWSRoute_IPv4_To_CarrierGateway
--- PASS: TestAccAWSRoute_IPv4_To_CarrierGateway (25.43s)
=== CONT  TestAccAWSRoute_IPv6_To_TransitGateway
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (401.51s)
--- PASS: TestAccAWSRoute_IPv4_Update_Target (700.08s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (47.75s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (198.43s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (25.76s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (380.22s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (176.28s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (60.62s)
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (381.16s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (60.70s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (50.13s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (26.15s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv4_To_Instance (326.49s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (35.98s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (39.12s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_disappears (32.59s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (308.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2928.423s
@YakDriver YakDriver force-pushed the f-r/aws_route-managed_prefix_list-destination branch from ba14669 to 5caf2e9 Compare March 29, 2021 15:28
YakDriver
YakDriver approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Code this neat gives me hope we will achieve consistency! 🎉

Acceptance tests on GovCloud:

--- PASS: TestAccAWSRoute_basic (55.93s)
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (59.42s)
--- PASS: TestAccAWSRoute_disappears (38.21s)
--- PASS: TestAccAWSRoute_disappears_RouteTable (46.11s)
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (55.60s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (80.80s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (193.98s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (143.21s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (184.69s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (69.89s)
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (389.45s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (42.61s)
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (61.27s)
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (59.16s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (112.44s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (54.60s)
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (69.33s)
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (335.95s)
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (42.47s)
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (65.25s)
--- PASS: TestAccAWSRoute_IPv6_Update_Target (273.03s)
--- PASS: TestAccAWSRoute_LocalRoute (38.60s)
--- SKIP: TestAccAWSRoute_IPv4_To_CarrierGateway (1.66s)
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (0.51s)
--- SKIP: TestAccAWSRoute_IPv4_To_VpcEndpoint (23.87s)
--- SKIP: TestAccAWSRoute_IPv4_Update_Target (0.35s)
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (0.69s)
--- SKIP: TestAccAWSRoute_PrefixList_To_CarrierGateway (1.62s)
--- SKIP: TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway (1.62s)
--- SKIP: TestAccAWSRoute_PrefixList_To_Instance (0.33s)
--- SKIP: TestAccAWSRoute_PrefixList_To_InternetGateway (0.40s)
--- SKIP: TestAccAWSRoute_PrefixList_To_LocalGateway (1.62s)
--- SKIP: TestAccAWSRoute_PrefixList_To_NatGateway (1.62s)
--- SKIP: TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached (1.62s)
--- SKIP: TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached (0.35s)
--- SKIP: TestAccAWSRoute_PrefixList_To_TransitGateway (1.62s)
--- SKIP: TestAccAWSRoute_PrefixList_To_VpcPeeringConnection (1.62s)
--- SKIP: TestAccAWSRoute_PrefixList_To_VpnGateway (0.34s)

Acceptance tests on commercial:

--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.58s)
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.65s)
--- SKIP: TestAccAWSRoute_PrefixList_To_LocalGateway (2.01s)
--- PASS: TestAccAWSRoute_LocalRoute (38.62s)
--- PASS: TestAccAWSRoute_IPv4_To_CarrierGateway (41.85s)
--- PASS: TestAccAWSRoute_PrefixList_To_VpcPeeringConnection (50.01s)
--- PASS: TestAccAWSRoute_PrefixList_To_InternetGateway (50.63s)
--- PASS: TestAccAWSRoute_PrefixList_To_CarrierGateway (50.81s)
--- PASS: TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway (52.92s)
--- PASS: TestAccAWSRoute_basic (55.19s)
--- PASS: TestAccAWSRoute_PrefixList_To_VpnGateway (65.06s)
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (69.87s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (25.88s)
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached (80.70s)
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (42.92s)
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (26.74s)
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (51.31s)
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (54.64s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (36.51s)
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (39.28s)
--- PASS: TestAccAWSRoute_PrefixList_To_Instance (121.73s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (58.98s)
--- PASS: TestAccAWSRoute_disappears_RouteTable (34.17s)
--- PASS: TestAccAWSRoute_disappears (33.82s)
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (60.68s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (122.64s)
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached (195.05s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (205.32s)
--- PASS: TestAccAWSRoute_PrefixList_To_NatGateway (211.32s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (165.02s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (181.74s)
--- PASS: TestAccAWSRoute_IPv6_Update_Target (250.16s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (310.09s)
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (400.58s)
--- PASS: TestAccAWSRoute_PrefixList_To_TransitGateway (402.98s)
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (411.85s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (423.91s)
--- PASS: TestAccAWSRoute_IPv4_Update_Target (584.01s)

@YakDriver YakDriver merged commit 19b8055 into hashicorp:main Mar 29, 2021
@github-actions github-actions bot added this to the v3.35.0 milestone Mar 29, 2021
@ewbankkit ewbankkit deleted the f-r/aws_route-managed_prefix_list-destination branch March 29, 2021 16:29
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit mentioned this pull request Apr 9, 2021
Closed
@ghost
Copy link

ghost commented Apr 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ewbankkit @randyspainhower @YakDriver