d/aws_route: 'destination_prefix_list_id' attribute set for managed prefix list destinations #17295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XXL
ewbankkit
changed the title
ewbankkit
force-pushed
the
f-d/aws_route-managed_prefix_list-destination
branch
from
fdf4964
to
0c3a48a
Compare
ewbankkit
commented
Jan 27, 2021
| rts.Primary.Attributes["id"], | ||
| ) | ||
| } | ||
| func TestAccAWSRouteDataSource_GatewayVpcEndpoint(t *testing.T) { |
There was a problem hiding this comment.
This test validates this change by adding a Gateway VPC Endpoint (S3), specifying that endpoint's prefix list ID to the data source and verifying that no route is returned.
ewbankkit
changed the title
This comment has been minimized.
This comment has been minimized.
ewbankkit
changed the title
This was referenced Mar 25, 2021
ewbankkit
force-pushed
the
f-d/aws_route-managed_prefix_list-destination
branch
2 times, most recently
from
2aad0e1
to
00b90ef
Compare
|
The |
…for managed prefix list destinations.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_DestinationPrefixListId' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_DestinationPrefixListId -timeout 120m === RUN TestAccAWSRouteDataSource_DestinationPrefixListId === PAUSE TestAccAWSRouteDataSource_DestinationPrefixListId === CONT TestAccAWSRouteDataSource_DestinationPrefixListId --- PASS: TestAccAWSRouteDataSource_DestinationPrefixListId (220.65s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 220.742s
Acceptance test output:
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 180m
=== RUN TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== RUN TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== RUN TestAccAWSRouteDataSource_CarrierGatewayID
=== PAUSE TestAccAWSRouteDataSource_CarrierGatewayID
=== RUN TestAccAWSRouteDataSource_DestinationPrefixListId
=== PAUSE TestAccAWSRouteDataSource_DestinationPrefixListId
=== RUN TestAccAWSRouteDataSource_GatewayVpcEndpoint
=== PAUSE TestAccAWSRouteDataSource_GatewayVpcEndpoint
=== CONT TestAccAWSRouteDataSource_basic
=== CONT TestAccAWSRouteDataSource_CarrierGatewayID
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (26.22s)
=== CONT TestAccAWSRouteDataSource_GatewayVpcEndpoint
--- PASS: TestAccAWSRouteDataSource_GatewayVpcEndpoint (44.20s)
=== CONT TestAccAWSRouteDataSource_DestinationPrefixListId
--- PASS: TestAccAWSRouteDataSource_basic (109.30s)
=== CONT TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (24.56s)
=== CONT TestAccAWSRouteDataSource_LocalGatewayID
data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (0.59s)
=== CONT TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_DestinationPrefixListId (220.48s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (390.35s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 524.910s
ewbankkit
force-pushed
the
f-d/aws_route-managed_prefix_list-destination
branch
from
00b90ef
to
4964548
Compare
ghost
added
size/L
YakDriver
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Looks great! 🎉
Acceptance tests in commercial:
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.39s)
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (25.22s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (25.27s)
--- PASS: TestAccAWSRouteDataSource_GatewayVpcEndpoint (41.80s)
--- PASS: TestAccAWSRouteDataSource_basic (89.40s)
--- PASS: TestAccAWSRouteDataSource_DestinationPrefixListId (219.00s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (380.64s)
Acceptance tests in GovCloud:
--- SKIP: TestAccAWSRouteDataSource_DestinationPrefixListId (1.59s)
--- SKIP: TestAccAWSRouteDataSource_CarrierGatewayID (1.61s)
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.86s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (27.01s)
--- PASS: TestAccAWSRouteDataSource_GatewayVpcEndpoint (44.53s)
--- PASS: TestAccAWSRouteDataSource_basic (111.36s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (351.68s)
|
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Builds on: #14014, #16930, #16961, #17291
Dependents: None (yet)
Relates: #14018, #15273.
Output from acceptance testing: