Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/generate import example for resources #1959

Merged
merged 10 commits into from
Aug 19, 2024
Merged

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Aug 16, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Description

Generate parameters needed for resource import. This uses the PrimaryIdentifier that is available in the schema.

References

Closes #696
Relates #1881

@johnsonaj johnsonaj marked this pull request as ready for review August 19, 2024 14:23
@johnsonaj johnsonaj requested a review from a team as a code owner August 19, 2024 14:23
@ewbankkit ewbankkit self-assigned this Aug 19, 2024
@ewbankkit ewbankkit added documentation code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. labels Aug 19, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@johnsonaj johnsonaj merged commit 6e0b4f3 into main Aug 19, 2024
9 checks passed
@johnsonaj johnsonaj deleted the f-generate-import-example branch August 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. documentation prioritized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better documentation for import of resources with composite identifiers
2 participants