Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: change format for import examples #1983

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Aug 28, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Description

Reduces effort for generating import examples for each resource. Data input has been shifted to json file for quicker processing instead of running executable for each import example

before: 248.20s
after: 0.29s

References

Relates #1959

@johnsonaj johnsonaj requested a review from a team as a code owner August 28, 2024 20:47
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj johnsonaj added code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. documentation labels Aug 29, 2024
@johnsonaj johnsonaj merged commit b684eb8 into main Aug 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. documentation prioritized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants